Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare to string method for GenericDataType and AmlipIdDataType #118

Merged
merged 1 commit into from
May 14, 2024

Conversation

irenebm
Copy link
Member

@irenebm irenebm commented May 13, 2024

Added a __str__() method to AmlipIdDataType and GenericDataType. This method returns a string representation of the object by calling its to_string() method.

Previously, the default representation was generic and uninformative:

<amlip_swig.AmlipIdDataType; proxy of <Swig Object of type 'eprosima::amlip::types::AmlipIdDataType *' at 0x74eabaf50960> >

With the addition of __str__(), the output becomes descriptive:

AMLMainNode.89.8e.a5.7f

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.81%. Comparing base (583c04f) to head (75e21a7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   51.04%   49.81%   -1.23%     
==========================================
  Files          64       64              
  Lines        3013     3013              
  Branches     1112     1112              
==========================================
- Hits         1538     1501      -37     
- Misses        653      682      +29     
- Partials      822      830       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rsanchez15 rsanchez15 merged commit 97d96e2 into main May 14, 2024
27 checks passed
@rsanchez15 rsanchez15 deleted the fix/data_type_py branch May 14, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants