[20274] Validate the YAML configuration file on parsing #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciaEchevarria99
requested changes
Apr 8, 2024
| @@ -30,6 +31,14 @@ YamlReader::get<mcap::McapWriterOptions>( | |||
| const Yaml& yml, | |||
| const YamlReaderVersion version) | |||
| { | |||
| const std::set<TagType> tags = { | |||
There was a problem hiding this comment.
Same comment as in the Pipe, I would save all the sets in yaml_configuration_tags.hpp
Tempate
force-pushed
the
feature/yaml_validator
branch
from
5073eb6
to
6dd9484
Compare
Signed-off-by: tempate <danieldiaz@eprosima.com> Validate YAML tags on parsing Signed-off-by: tempate <danieldiaz@eprosima.com> Validate new YAML options Signed-off-by: tempate <danieldiaz@eprosima.com> Make sets static Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Tempate
force-pushed
the
feature/yaml_validator
branch
from
6dd9484
to
d2c218b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this version, the DDS Recorder and the DDS Replayer throw a warning when a YAML tag is ignored to prevent typos, misplacements, and wrong configurations.
Merge after: