-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20334] Make the resource limits consistent after changing states #140
base: main
Are you sure you want to change the base?
Conversation
a897e4f
to
5939a05
Compare
5c45245
to
a36b9f8
Compare
a36b9f8
to
eeeac82
Compare
dca18e6
to
f434a33
Compare
adff96f
to
dcc9f62
Compare
dcc9f62
to
53d0e2a
Compare
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
53d0e2a
to
ab73b8d
Compare
Signed-off-by: tempate <danieldiaz@eprosima.com>
ab73b8d
to
a9c882c
Compare
ddsrecorder_participants/include/ddsrecorder_participants/recorder/mcap/McapHandler.hpp
Show resolved
Hide resolved
Signed-off-by: tempate <danieldiaz@eprosima.com>
Signed-off-by: tempate <danieldiaz@eprosima.com>
@@ -41,7 +41,9 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include ddspipe_core/types/dds/Payload.hpp
DDSRECORDER_MCAP_HANDLER, | ||
"Ignoring stop command, instance already stopped."); | ||
logWarning(DDSRECORDER_MCAP_HANDLER, | ||
"MCAP_STATE | Ignoring stop command, instance already stopped."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like this name, it's not giving information about the MCAP state but about the MCAPHANDLER
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is the McapHandler is a concept that comes from how the code works. A user shouldn't be aware of what the McapHandler is or what it's in charge of. It should just know high level concepts, like state and write.
Signed-off-by: tempate <danieldiaz@eprosima.com>
In the previous version, the resource limits only applied to the DDS Recorder while it was running: as soon as the DDS Recorder received a STOP, the resource limits were reset. In this version, the DDS Recorder can rotate the files from a previous running session. Moreover, in this version users can also set AVOID_OVERWRITING_FILES when stopping to save a set of files from the DDS Recorder rotations.
This version also fixes some bugs.
Merge after: