Unknown warning option on OSX

[Karsten1987]

When compiling locally on my machine (-DCMAKE_CXX_FLAGS=-Werror), my clang compiler complains about two unsupported warnings:

error: : unknown warning option '-Wlogical-op'; did you mean '-Wlong-long'?

error: : unknown warning option '-Wuseless-cast'

Both are found in here:
https://github.com/eProsima/Fast-CDR/blob/master/cmake/common/check_configuration.cmake#L129-L130

OSX: macOS Sierra, Version 10.12.6
CLANG: clang version 7.0.0 (https://llvm.org/git/clang.git 4f6bfc6f7dced31f46786058f1c8472d3b2b215a) (https://llvm.org/git/llvm.git d9367a91972e6631f831c329a47856785031d58e)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /usr/local/opt/llvm/bin

[richiware]

Those warning options should be only supported by GNU GCC. Commit 1df42bb should solve your problem. Now we check whether compiler is GNU GCC or not. ↪ 2018-08-07 mar 19:08, Karsten Knese <notifications@github.com>:

…

When compiling locally on my machine (`-DCMAKE_CXX_FLAGS=-Werror`), my clang compiler complains about two unsupported warnings: ``` error: : unknown warning option '-Wlogical-op'; did you mean '-Wlong-long'? ``` ``` error: : unknown warning option '-Wuseless-cast' ``` Both are found in here: https://github.com/eProsima/Fast-CDR/blob/master/cmake/common/check_configuration.cmake#L129-L130 OSX: macOS Sierra, Version 10.12.6 CLANG: clang version 7.0.0 (https://llvm.org/git/clang.git 4f6bfc6f7dced31f46786058f1c8472d3b2b215a) (https://llvm.org/git/llvm.git d9367a91972e6631f831c329a47856785031d58e) Target: x86_64-apple-darwin16.7.0 Thread model: posix InstalledDir: /usr/local/opt/llvm/bin -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #22

[Karsten1987]

that seems to work. Thanks for the update.