Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for new gradle versions #129

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Support for new gradle versions #129

merged 3 commits into from
Aug 31, 2022

Conversation

richiware
Copy link
Member

@richiware richiware commented Aug 4, 2022 •
edited
Loading

@richiware
Refs #15294. Support for new gradle versions
7167d9c 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware mentioned this pull request Aug 4, 2022
Merged
@MiguelCompany MiguelCompany mentioned this pull request Aug 30, 2022
Closed
@MiguelCompany MiguelCompany linked an issue Aug 30, 2022 that may be closed by this pull request
gradle assemble fails on line 94 [13732] #56
Closed
MiguelCompany
MiguelCompany requested changes Aug 30, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to also upgrade gradlew and gradlew.bat

@richiware
Refs #15294. Update gradlew to 7.0
d282cbe 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
MiguelCompany
MiguelCompany previously approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Member Author

Updated gradlew as suggested

@richiware
Refs #15294. Update idl-parser submodule
6d6b435 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
MiguelCompany
MiguelCompany approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@richiware richiware merged commit 3ef89ed into master Aug 31, 2022
@richiware richiware deleted the feature/support-new-gradle branch August 31, 2022 11:44
This was referenced Aug 31, 2022
Closed
Closed
Closed
@pablogs9 pablogs9 mentioned this pull request Sep 5, 2022
Closed
@JLBuenoLopez JLBuenoLopez mentioned this pull request Oct 27, 2022
Closed
@JLBuenoLopez JLBuenoLopez mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gradle assemble fails on line 94 [13732]
2 participants
@richiware @MiguelCompany