[19680] Enable -Wall, fix build warnings and fix regression
#246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
…dule in a union Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
JLBuenoLopez
changed the title
-Wall, fix build warnings and fix [regression](https://github.com/eProsima/dds-types-test/pull/9)-Wall, fix build warnings and fix regression
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
JLBuenoLopez
force-pushed
the
bugfixes/warnings-regressions
branch
from
91ec231
to
c30dfd7
Compare
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
richiware
requested changes
Oct 9, 2023
src/main/java/com/eprosima/fastdds/idl/templates/SerializationSource.stg
Outdated
Show resolved
Hide resolved
src/main/java/com/eprosima/fastdds/idl/templates/TypesCdrAuxHeaderImpl.stg
Outdated
Show resolved
Hide resolved
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
JLBuenoLopez
force-pushed
the
bugfixes/warnings-regressions
branch
from
3c9a484
to
c1619ee
Compare
richiware
requested changes
Oct 9, 2023
src/main/java/com/eprosima/fastdds/idl/templates/DDSPubSubTypeSource.stg
Outdated
Show resolved
Hide resolved
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
richiware
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression.
This PR depends on: