Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20723] Include v2.13.4 release notes #743

Merged
merged 2 commits into from
May 7, 2024
Merged

[20723] Include v2.13.4 release notes #743

merged 2 commits into from
May 7, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Apr 4, 2024 •
edited by EduPonz

Description

This PR includes the release notes of Fast DDS v2.13.4 in latest documentation (master)

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@JesusPoderoso
Refs #20723: Include v2.13.4 release notes
5ad4f5b 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added this to the v2.14.1 milestone Apr 4, 2024
@JesusPoderoso JesusPoderoso self-assigned this Apr 4, 2024
@Mario-DL
Copy link
Member

We may be missing to update docs/notes/versions.rst Shapes Demo related version in 2.13.x to v2.13.4

@JesusPoderoso
Refs #20723: Apply Mario' suggestion
6cba5e8 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test this

Mario-DL
Mario-DL approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Green CI

@EduPonz EduPonz merged commit cb96a6c into master May 7, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/v2.13.4_release_notes branch May 7, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
ci-pending
Projects
None yet
Milestone
v2.14.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JesusPoderoso @Mario-DL @EduPonz