Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20849] New max_message_size property to limit output datagrams size (backport #770) #777

Open
wants to merge 1 commit into
base: 2.6.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 17, 2024

Description

This PR adds the documentation for max_message_size property in RTPS Writer and RTPS Participant.

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

This is an automatic backport of pull request #770 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label May 17, 2024
Copy link
Author

mergify bot commented May 17, 2024

Cherry-pick of 91d96b8 has failed:

On branch mergify/bp/2.6.x/pr-770
Your branch is up to date with 'origin/2.6.x'.

You are currently cherry-picking commit 91d96b8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   code/DDSCodeTester.cpp
	both modified:   code/XMLTester.xml
	both modified:   docs/fastdds/property_policies/non_consolidated_qos.rst

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

* Refs #20849: Add max_message_size property policy docs

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs 20849: Apply suggestions

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20849: Apply suggestions

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit 91d96b8)
@Mario-DL
Copy link
Member

Mario-DL commented Jun 5, 2024

I saw that the implementation PR (eProsima/Fast-DDS#4777) was not backported to 2.6.x. Is this feature going to be in 2.6.x ?
CC: @elianalf @MiguelCompany

@MiguelCompany
Copy link
Member

I saw that the implementation PR (eProsima/Fast-DDS#4777) was not backported to 2.6.x. Is this feature going to be in 2.6.x ? CC: @elianalf @MiguelCompany

I forgot to backport from 2.10.x. Requested here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants