Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support custom participant qos and fixed datareader entity ids [12474] #124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

richiware
Copy link
Member

Signed-off-by: Ricardo González Moreno ricardo@richiware.dev

@richiware richiware changed the title Support custom participant qos and fixed datareader entity ids WIP: Support custom participant qos and fixed datareader entity ids [12474] Sep 7, 2021
@richiware richiware temporarily deployed to codecov September 9, 2021 14:09 Inactive
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #124 (ed387c6) into main (1426da3) will increase coverage by 0.12%.
The diff coverage is 68.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   57.93%   58.06%   +0.12%     
==========================================
  Files          31       31              
  Lines        4308     4359      +51     
  Branches     2311     2339      +28     
==========================================
+ Hits         2496     2531      +35     
- Misses         50       63      +13     
- Partials     1762     1765       +3     
Impacted Files Coverage Δ
src/cpp/StatisticsBackend.cpp 48.71% <68.62%> (+2.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1426da3...ed387c6. Read the comment docs.

@richiware richiware force-pushed the feature/custom-participant-qos branch from a2d326b to ed387c6 Compare October 22, 2021 08:59
@richiware richiware temporarily deployed to codecov October 22, 2021 08:59 Inactive
@richiware richiware temporarily deployed to codecov October 22, 2021 08:59 Inactive
@JLBuenoLopez
Copy link
Contributor

@richiware what is the status of this PR? Is it still a WIP? If so, can you convert it into Draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants