Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stateful writer improvements [7925] #1063

Merged
merged 6 commits into from Mar 17, 2020
Merged

Stateful writer improvements [7925] #1063

merged 6 commits into from Mar 17, 2020

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Mar 12, 2020 •
edited

While checking #1062, I discovered that we could save some CPU usage with the changes on this PR. Note that it does not fix the issue, but I saw some improvement.

After further investigation, and recovering piggyback heartbeats on 6893b5d, this fixes #1062

@MiguelCompany MiguelCompany changed the title Stateful writer improvements Stateful writer improvements [7925] Mar 12, 2020
IkerLuengo
IkerLuengo previously approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

IkerLuengo
IkerLuengo previously approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany force-pushed the bugfix/stateful-writer-improvements branch from 16d215b to 6893b5d Compare March 16, 2020 08:23
IkerLuengo
IkerLuengo previously approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany
Copy link
Member Author

MiguelCompany commented Mar 16, 2020 •
edited

Windows gave stderr: fatal: reference is not a tree: 9c2c071f1733d8fa0afe19bf73560d36af2476d1, due to #859 being merge just before build started, relaunching:

  • Windows Build Status
    • Some known flaky failures.

@MiguelCompany MiguelCompany added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 16, 2020
@MiguelCompany MiguelCompany added this to the v1.10.0 milestone Mar 16, 2020
@MiguelCompany MiguelCompany mentioned this pull request Mar 16, 2020
Closed
@MiguelCompany MiguelCompany force-pushed the bugfix/stateful-writer-improvements branch from 6893b5d to 2b32541 Compare March 17, 2020 06:27
@MiguelCompany MiguelCompany force-pushed the bugfix/stateful-writer-improvements branch from 2b32541 to 8b90f25 Compare March 17, 2020 06:29
@richiware
Copy link
Member

richiware commented Mar 17, 2020 •
edited by MiguelCompany

Build status:

@MiguelCompany MiguelCompany merged commit 1e403b4 into master Mar 17, 2020
@MiguelCompany MiguelCompany deleted the bugfix/stateful-writer-improvements branch March 17, 2020 10:04
@MiguelCompany MiguelCompany mentioned this pull request Apr 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adolfomarver adolfomarver adolfomarver approved these changes

@IkerLuengo IkerLuengo IkerLuengo left review comments

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MiguelCompany @richiware @adolfomarver @IkerLuengo