Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20025] Fix branch selection on Github CI #4091

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

EduPonz
Copy link
Member

@EduPonz EduPonz commented Dec 4, 2023

Description

This PR:

  1. Fixes the fallback branch for the gh docs CI
  2. Fixes the selected .repos file for windows gh CI on push events to 2.12.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v2.12.2 milestone Dec 4, 2023
@EduPonz EduPonz added the skip-ci Automatically pass CI label Dec 4, 2023
@EduPonz
Copy link
Member Author

EduPonz commented Dec 4, 2023

@richiprosima please test this

@EduPonz EduPonz added needs rebase and removed skip-ci Automatically pass CI labels Dec 4, 2023
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the hotfix/2.12.x/gh_ci_branches branch from 92f4658 to af232a1 Compare December 4, 2023 09:52
@EduPonz EduPonz added ci-pending PR which CI is running and removed needs rebase labels Dec 4, 2023
@EduPonz EduPonz merged commit 8397aad into 2.12.x Dec 4, 2023
6 of 8 checks passed
@EduPonz EduPonz deleted the hotfix/2.12.x/gh_ci_branches branch December 4, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants