Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds liveliness QoS [5621] #560

Merged
merged 48 commits into from
Jun 25, 2019
Merged

Adds liveliness QoS [5621] #560

merged 48 commits into from
Jun 25, 2019

Conversation

raquelalvarezbanos
Copy link
Contributor

No description provided.

@raquelalvarezbanos raquelalvarezbanos changed the title Adds liveliness QoS Adds liveliness QoS [5621] Jun 11, 2019
@LuisGP LuisGP self-requested a review June 11, 2019 13:05
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

LuisGP
LuisGP suggested changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@LuisGP LuisGP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following tests failed in my review:

LivelinessManagerTests.TimerExpired_ManualByParticipant
LivelinessManagerTests.TimerExpired_ManualByTopic
LivelinessManagerTests.TimerOwnerCalculation
LivelinessManagerTests.TimerOwnerRemoved

Adding some example cases in the example's readme file would be nice.

Testing/Temporary/CTestCostData.txt Outdated Show resolved Hide resolved
examples/C++/LivelinessQoS/Liveliness_main.cpp Outdated Show resolved Hide resolved
examples/C++/LivelinessQoS/README.md Outdated Show resolved Hide resolved
include/fastrtps/rtps/builtin/liveliness/WLP.h Outdated Show resolved Hide resolved
include/fastrtps/rtps/builtin/liveliness/WLP.h Outdated Show resolved Hide resolved
src/cpp/rtps/reader/StatelessReader.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/reader/StatelessReader.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/writer/LivelinessManager.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/writer/LivelinessManager.cpp Outdated Show resolved Hide resolved
test/blackbox/BlackboxTestsLivelinessQos.cpp Show resolved Hide resolved
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany added this to the v1.8.1 milestone Jun 18, 2019
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Raquel Alvarez added 18 commits June 19, 2019 15:07
Refs #5183 Adding C++ example of liveliness with one AUTOMATIC publisher
5c8bb45
Refs #5183 Extending C++ examples to allow using a participant with t…
db06977 
…wo publishers
Refs #5183 Extending C++ example to allow configuration of liveliness…
2b0892d 
… kind
Refs #5060 Format changes only
651021a
Refs #5060 Removing WriterProxyLiveliness and adding new classes
ea84505
Refs #5060 Adding liveliness manager to RTPSReader and WLP
b275273
Refs #5060 Removing liveliness information from WriterProxyData
5c8b207
Refs 5060 Adding functionality to liveliness manager + unit tests
aa877f2
Refs #5060 Adding liveliness methods at the reader-writer layer
ed5c8f5
Refs #5060 Updating WLP so that it invokes writer listener when livel…
67a2dc6 
…iness of writer is lost
Refs #5060 Adding callbacks to pub-sub layer
a36b2dd
Refs #5060 Implementing getters for liveliness status
0d9a0da
Refs #5060 Changes to implement assert_liveliness() method
8291c88
Refs #5060 Adding option to liveliness manager to exclude automatic w…
76ff3e8 
…riters
Refs #5060 Fixing WLP so that liveliness manager is created when WLP …
4e82af8 
…is initialized
Refs #5060 Fixing WLP so that liveliness manager is created when WLP …
31b4d7d 
…is initialized. Also liveliness is not changeable
Refs #5060 Changes to WLP to make AUTOMATIC (writer) - AUTOMATIC (rea…
2ae19ed 
…der) work
Refs #5060 Changes to WLP to make MANUAL_BY_PARTICIPANT (w) - MANUAL_…
254e4e5 
…BY_PARTICIPANT (r) work
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@eProsima eProsima deleted a comment from richiware Jun 19, 2019
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

LuisGP
LuisGP previously approved these changes Jun 21, 2019
View reviewed changes
@LuisGP
Copy link
Contributor

LuisGP commented Jun 21, 2019

LGTM

LuisGP
LuisGP approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@LuisGP LuisGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@raquelalvarezbanos
Copy link
Contributor Author

raquelalvarezbanos commented Jun 24, 2019 •
edited
Loading

Run the tests locally:

mkdir jenkins/src
cd jenkins
git clone https://github.com/eProsima/Fast-RTPS.git src/fastrtps
cd src/fastrtps
git fetch origin +refs/pull/560/merge
git checkout FETCH_HEAD
cd ../../
python3 buildcop.py --ci-repo https://gitlab.intranet.eprosima.com/eProsima/fastrtps-ci.git --source-branch feature/LivelinessQoS --target-branch develop --build-args --mixin rel-with-deb-info --event-handlers console_cohesion+ console_pa\
ckage_list+ --packages-up-to fastrtps --cmake-args -DSECURITY=ON --- --test-args --packages-up-to --ctest-args --timeout 300
  • On Ubuntu
    • All tests passed
  • On Windows:
    • 2017: all tests passed
    • 2015: all tests passed
  • On mac:
    • TwentyParticipantsSeveralEndpoints failed (segfault) in the first execution on closing participants (failure unrelated to this PR)

@richiware richiware merged commit 26b1f56 into develop Jun 25, 2019
@richiware richiware deleted the feature/LivelinessQoS branch June 25, 2019 14:30
raquelalvarezbanos pushed a commit that referenced this pull request Jun 28, 2019
@MiguelCompany @raquelalvarezbanos
Release 1.8.1 [5693] (#574)
0835a86 
* Refs #5496 Reordering code to avoid data race on StatefulWriter destructor. (#546)

* Fix lroundl error on Windows. [5505] (#549)

* Refs #5313 Fix lroundl error on Windows.

* Refs #5505 Sugested changes

* Refs #5505 Removed unnecessary parenthesis and clang warnings.

* Adds tests for ReaderHistory [5503] (#547)

* Refs #5486. First tests for ReaderHistory

GetRepeatedSequenceNumber test will fail until the bug is fixed

* Refs #5486. Added more tests for ReaderHistory

GetChange test will fail until the bug is fixed

Also fixed a bug in ReaderHistory::remove_changes_with_guid function. The comparison between writerGUIDs was wrong. operator == is used instead.

* Refs #5486. Fixed memory leaks

* Refs #5486. Fixed Windows warnings

* Refs #5486. Code Style

* Refs #5486. Fixed Mac Warning

* Refs #5486. Fixed Mac Warning

* Refs #5486. Removed set_reader function from ReaderHistory. Added new constructor to the StatefulReader mock instead.

* Refs #5486. Added default constructors

* Refs #5486. Removed code needed

* Refs #5486. Fix error in RTPSReader mock (security did not pass)

* Fixing data race on UDPTransportInterface [5458] (#540)

* Refs #5458. Fixing data race on UDPTransportInterface.

* Refs #5458. Fixing timeouts on Mac.

* Refs #5458 Fixing data race on ReceiverResource dtor.

* Refs #5458 Clang-tidy warnings

* Refs #5458 Fixing Mac timeout.

* Refs #5458 Fixing valgrind invalid read.

* Refs #5458 Requested changes.

* Refs #5458 Fixing situation when socket doesn't close nicely.

* Refs #5458 Trying to fix Mac issue.

* Refs #5458 Trying to fix Mac issue.

* Refs #5458 Trying to fix Mac issue.

* Refs #5458 Fixed Mac issue.

* Refs #5458 Avoid loop when multicast. Much lesser wait time until continue.

* Refs #5458 Requested changes.

* Tests for CacheChangePool [5599] (#557)

* Refs #5551. First tests for CacheChangePool

* Ignoring files for Eclipse and Visual Studio Code

* Refs #5551. Tests for reserve_Cache function

* Refs #5551. Improved tests for reserve_Cache function. Deleted CacheChangePoolAttributes, it uses a tuple and the Combine method instead.

* Refs #5551. Added two more tests for CacheChangePool
Checks the initialized status of a reserved cache_changed
Checks the size of allChanges and freeChanges vectors

* Refs #5552. Blackbox run with prealloc memory mode only

* Refs #5552. Fixed certificate xml files and regenerated smime files
Also fixed bug in BlackboxTestsPersistence. Byte for Prealloc Memory Mode is '3'

* Refs #5551. Fixed gtest comparisons between signed and unsigned types
Replaced EXPECT with ASSERT

* Refs #5551. Fixed Instanciation tests for Mac

* Added discovery regression test [5479] (#542)

* Refs #5453 Adding a test for discovery with thirty participants

* Refs #5453 Updating the test to check for matched readers/writers

* Refs #5453. Added test for multiple participants with multiple topics.

* Refs #5479. Fixing warnings on Mac.

* Refs #5479. Changed test to fail by timeout pattern.

* Refs #5479. Taking removal and unmatching into account.

* Refs #5479. Styling and no copy.

* Refs #5479. Fixing valgrind.

* Refs #5479. Avoiding possible port collisions.

* Refs #5479. Removing debug print methods.

* Refs #5479. Adding debug messages to persistence tests.

* Refs #5479. Closing participants.

* Refs #5479. Adding more info to persistence tests.

* Refs #5479. Fix build errors after rebase.

* Refs #4579. Addressing review comments.

* Log error when default profiles xml loads with error + unittest [5596] (#556)

* Log error when default profiles xml loads with error + unittest

* More verbose error

* log opening error also when the file is DEFAULT_FASTRTPS_PROFILES

* combine xml loading and error checking

* Using java 1.8 [5705] (#567)

* Refs #5693. Updating idl and fastcdr submodules

* Refs #5697. Targetting java 1.8

* Refs #5697. Adding linter options.

* Refs #5697. Fixing warnings.

* Do not print the error if the filename is the default (#568)

* Refs #5746: delete the periodic HB after stopping reader proxies (#572)

* Fix closing multicast UDP channel with whitelist [5732] (#569)

* Refs #5714. Added unit test.

* Refs #3463. On releasing UDP resources, if the closing of the UDP fails 10 times, shut it down manually.

* Refactor without sending close message

* Refs #5714 remove UDPTransportInterface::ReleaseInputChannel

* Wait until the UDPChannelResource::perform_listen_operation has joined before deleting the channel resource

* Refs #5714 Simplify channel resource release mechanism. Eliminates condition variable and mutex

* Adds liveliness QoS [5621] (#560)

* Refs #5183 Adding C++ example of liveliness with one AUTOMATIC publisher

* Refs #5183 Extending C++ examples to allow using a participant with two publishers

* Refs #5183 Extending C++ example to allow configuration of liveliness kind

* Refs #5060 Format changes only

* Refs #5060 Removing WriterProxyLiveliness and adding new classes

* Refs #5060 Adding liveliness manager to RTPSReader and WLP

* Refs #5060 Removing liveliness information from WriterProxyData

* Refs 5060 Adding functionality to liveliness manager + unit tests

* Refs #5060 Adding liveliness methods at the reader-writer layer

* Refs #5060 Updating WLP so that it invokes writer listener when liveliness of writer is lost

* Refs #5060 Adding callbacks to pub-sub layer

* Refs #5060 Implementing getters for liveliness status

* Refs #5060 Changes to implement assert_liveliness() method

* Refs #5060 Adding option to liveliness manager to exclude automatic writers

* Refs #5060 Fixing WLP so that liveliness manager is created when WLP is initialized

* Refs #5060 Fixing WLP so that liveliness manager is created when WLP is initialized. Also liveliness is not changeable

* Refs #5060 Changes to WLP to make AUTOMATIC (writer) - AUTOMATIC (reader) work

* Refs #5060 Changes to WLP to make MANUAL_BY_PARTICIPANT (w) - MANUAL_BY_PARTICIPANT (r) work

* Refs #5060 Changes to WLP to make MANUAL_BY_TOPIC (w) - MANUAL_BY_TOPIC (r) work

* Refs #5060 Changes to stateless reader and writer

* Refs #5060 Implementing assert_liveliness method

* Refs #5060 Changes to allow different liveliness kinds between writer/reader

* Refs #5060 Combining some blackbox tests

* Refs #5060 Code clean-up

* Refs #5060 Testing more than one pub/sub in the same participant

* Refs #5060 Code clean up

* Refs #5060 Fixing deadlock

* Refs #5060 More code clean up

* Refs #5060 Trying to fix builds

* Refs #5060 Trying to fix build of tests

* Refs #5060 Fixing error message that shouldn't be logged

* Refs #5060 Fixing warnings and trying to make tests for stable when running valgrind

* Refs #5060 Addressing review comments

* Refs #5060 Adding a python test for automatic liveliness

* Refs #5058 Fixing windows builds

* Refs #5060 Fixing mac warnings

* Refs #5060 Fixing mac build

* Refs #5060 Fixing failing test on mac

* Refs #5060 Trying to make some tests more stable when using valgrind

* Refs #5060 Trying to make tests more stable by using condition variables

* Refs #5060 Resolving remaining review comments

* Refs #5060 Making some tests more stable on windows

* Refs #5060 Fixing remaining tabs

* Refs #5060 Fixing mac warning

* Refs #5060 Making some ests more stable on mac

* Refs #5060 Trying to fix remaining test that is failing on mac

* Refs #5060 Removing asserts and letting timers manage non-positive intervals

* Refs #5060 Adding explanation about non-positive intervals

* Refs #5693. Bump version to 1.8.1

* Refs #5761 Fixing liveliness manager tests that would fail with GTEST_INDIVIDUAL OFF (#577)

* Fix for liveliness changed struct (#578)

* Refs #5765 Adding a test

* Refs #5765 Fix for liveliness changed status

* Refs #5765 Adding more tests

* Refs #5765 Addressing some review comments

* Refs #5765 Adding indentation

* Adding assert_liveliness to participant (#579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuisGP LuisGP LuisGP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raquelalvarezbanos @richiware @LuisGP @MiguelCompany