Noticing some design side-effects #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
approved these changes
Nov 5, 2019
MiguelCompany
pushed a commit
that referenced
this pull request
Nov 14, 2019
MiguelCompany
added a commit
that referenced
this pull request
Nov 14, 2019
* Refs #6567. Intra process proposal * Refs #6567. Updated after last decision on reception side. * Noticing some design side-effects (#843) * Created additional considerations section * Refs #6567. Updated intraprocess design removing discovery intentions. * Refs #6567. Stating that PDP does not use intraprocess. * Refs #6567. Better explanations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New design side-effects
This design isolates all message traffic from the wire, that is, tools like wireshark™ will become useless. Given that most of our customers actually run intraprocess code, and report their issues using wireshark™ traces, these changes will create a support nightmare. A workaround may be to supply a flag to inhibit the intraprocess behavior for debugging purposes, stating clearly, that it should be turn off during performance test.
Once a shared memory transport is developed for interprocess purposes, an intraprocess mechanism would be pointless. That's because the trade off between speed gain and source complexity would be very expensive. From memory consumption point of view using an interprocess discovery database would yield more benefits that having per-process discovery databases.