Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared memory transport design documents <master> [7932] #859
Shared memory transport design documents <master> [7932] #859
Changes from 9 commits
608adf5
1d7be55
65592f3
9b4220d
6418c6a
ed2f58d
8b5012c
6f5f175
703bea4
280bd6e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the definition by machine? including container which actually in the same machine?
this is also related to how it can detect if inter-process or not, but i guess that better to mention that also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's true "machine" is not a precise definition, The idea is that shared-memory will improve communications between processes capable of sharing local memory, that running in the same operating system instance in a machine, but of course processes running in the same container or virtual machine but not intercontainer or virtual machines.
How could we well define this idea in a phrase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there already plan how it provide the interface to configure the memory space? API or configuration file to load?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The memory space can be configured through the transport descriptor, that can be done in the application's C++ code or with an external XML file using the fastrtps XML profiles feature.