Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for eWaterCycleModel #378

Merged
merged 11 commits into from
Oct 5, 2023
Merged

Tests for eWaterCycleModel #378

merged 11 commits into from
Oct 5, 2023

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Sep 14, 2023 •
edited
Loading

Fixes #372

Refs #373 by storing models in ewatercycle.testing.fake_models package.

Also changes model.parameters type from dict to ItemsView to be inline with pymt

@sverhoeven sverhoeven marked this pull request as ready for review October 2, 2023 08:10
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

98.9% 98.9% Coverage
0.0% 0.0% Duplication

BSchilperoort
BSchilperoort approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sverhoeven sverhoeven merged commit ad99ebf into main Oct 5, 2023
5 checks passed
@sverhoeven sverhoeven deleted the base-model-tests branch October 5, 2023 08:01
@Peter9192 Peter9192 mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSchilperoort BSchilperoort BSchilperoort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tests for abstractmodel to test the new API
2 participants
@sverhoeven @BSchilperoort