Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in an XQuery file for xqproc #2532

Closed
lcahlander opened this issue Mar 7, 2019 · 7 comments
Closed

Typo in an XQuery file for xqproc #2532

lcahlander opened this issue Mar 7, 2019 · 7 comments
Labels
bug issue confirmed as bug

Comments

@lcahlander
Copy link
Contributor

What is the problem

in exist/extensions/xprocxq/main/src/xquery/std.xqm line 104 has : = instead of :=

What did you expect

Fix the typo

Describe how to reproduce or add a test

N/A

Context information

Please always add the following information

  • eXist-db version + Git Revision hash e.g. eXist-db 5.0 / develop/1ae05530
  • Java version 1.8.0_192
  • Operating system MacOs
  • 64 bit
  • How is eXist-db installed? clone from GitHub
  • Any custom changes N/A
@triage-new-issues triage-new-issues bot added the triage issue needs to be investigated label Mar 7, 2019
@joewiz
Copy link
Member

joewiz commented Mar 8, 2019

Here's the link: https://github.com/eXist-db/exist/blob/develop/extensions/xprocxq/main/src/xquery/std.xqm#L104

That same file contains a static error:

Cannot compile xquery: err:XQST0033 Cannot bind prefix 'err' to 'http://www.w3.org/ns/xproc-error' it is already bound to 'http://www.w3.org/2005/xqt-errors'

While the spec's section about err says, "This namespace prefix is not predeclared," eXist does bind it, so this module couldn't pass static compilation...

Is anyone using xprocxq? The repo history says it's by @xquery, and hasn't been touched besides build maintenance in 8-10 years. See https://github.com/eXist-db/exist/tree/develop/extensions/xprocxq/main. As an implementation of XProc, I know that https://github.com/eXist-db/xquery-xproc-xmlcalabash-module is in use in production today and is probably quite a bit more up to date with the XProc standard, because XML Calabash itself is a reference implementation.

I raise this to ask if we want to keep it in the code base? Perhaps it's a topic for a future community call?

@dizzzz
Copy link
Member

dizzzz commented Mar 8, 2019

it is old and abandoned code IMO. The concept is very nice though....

@dizzzz
Copy link
Member

dizzzz commented Mar 8, 2019

Xproc has become much more usable starting with v3 .....

@duncdrum duncdrum added bug issue confirmed as bug discuss ask for feedback labels Mar 8, 2019
@triage-new-issues triage-new-issues bot removed the triage issue needs to be investigated label Mar 8, 2019
@duncdrum
Copy link
Contributor

duncdrum commented Mar 8, 2019

Well i think replacing this code with the one Joe linked to sounds like a good idea. However, this would be a deprecation which we could add to 5.0.0 but it needs to be marked as such. Also there is the need for documentation if we go the deprecation route. If we are not willing to deprecate this for 5.0.0 we should simple fix the bug.

@lcahlander
Copy link
Contributor Author

If it is going to be deprecated, then it should be fixed until we actually remove it. It should only be as an installable module as https://github.com/eXist-db/xquery-xproc-xmlcalabash-module. However, until it is removed, it should be working. Until it is removed, each of the XQuery files should have the following added to the header:

(:~
 : @deprecated 
 : *2019-03-08*
 : To be removed in version 6 of eXist-db.  
 : Please use the `xquery-xproc-xmlcalabash-module` from the Package Manager.
 :)

or something like it.

@adamretter
Copy link
Member

@joewiz I think we should simply remove xprocxq. As you pointed out it is now 8 - 10 years out of date!

@grantmacken
Copy link

grantmacken commented Mar 9, 2019

Toss it overboard. And anything else that does not move when you poke a stick at it

@duncdrum duncdrum added needs documentation Signals issues or PRs that will require an update to the documentation repo and removed discuss ask for feedback labels Mar 11, 2019
@duncdrum duncdrum removed the needs documentation Signals issues or PRs that will require an update to the documentation repo label Mar 12, 2019
claudius108 pushed a commit to claudius108/exist that referenced this issue Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issue confirmed as bug
Projects
None yet
Development

No branches or pull requests

6 participants