-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in an XQuery file for xqproc #2532
Comments
Here's the link: https://github.com/eXist-db/exist/blob/develop/extensions/xprocxq/main/src/xquery/std.xqm#L104 That same file contains a static error:
While the spec's section about Is anyone using xprocxq? The repo history says it's by @xquery, and hasn't been touched besides build maintenance in 8-10 years. See https://github.com/eXist-db/exist/tree/develop/extensions/xprocxq/main. As an implementation of XProc, I know that https://github.com/eXist-db/xquery-xproc-xmlcalabash-module is in use in production today and is probably quite a bit more up to date with the XProc standard, because XML Calabash itself is a reference implementation. I raise this to ask if we want to keep it in the code base? Perhaps it's a topic for a future community call? |
it is old and abandoned code IMO. The concept is very nice though.... |
Xproc has become much more usable starting with v3 ..... |
Well i think replacing this code with the one Joe linked to sounds like a good idea. However, this would be a deprecation which we could add to 5.0.0 but it needs to be marked as such. Also there is the need for documentation if we go the deprecation route. If we are not willing to deprecate this for 5.0.0 we should simple fix the bug. |
If it is going to be deprecated, then it should be fixed until we actually remove it. It should only be as an installable module as https://github.com/eXist-db/xquery-xproc-xmlcalabash-module. However, until it is removed, it should be working. Until it is removed, each of the XQuery files should have the following added to the header:
or something like it. |
@joewiz I think we should simply remove |
Toss it overboard. And anything else that does not move when you poke a stick at it |
What is the problem
in
exist/extensions/xprocxq/main/src/xquery/std.xqm
line 104 has: =
instead of:=
What did you expect
Fix the typo
Describe how to reproduce or add a test
N/A
Context information
Please always add the following information
The text was updated successfully, but these errors were encountered: