Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding product-version (and git commit ID) to launcher spash screen #288

Conversation

ljo
Copy link
Member

@ljo ljo commented Aug 5, 2014

No description provided.

@JoernT
Copy link
Member

JoernT commented Aug 5, 2014

Which brings me to another question/request.

Can we already distinguish a community from an LTS build? Shouldn't we
not even put 'LTS' as part of the version? E.g.

Version 2.1.6 LTS

Am 05.08.14 23:02, schrieb ljo:

You can merge this Pull Request by running:

git pull https://github.com/ljo/exist feature/add-product-version-to-launcher-spash-screen

Or you can view, comment on it, or merge it online at:

#288

-- Commit Summary --

  • Adding product-version (and git commit ID) to launcher spash screen

-- File Changes --

M src/org/exist/client/InteractiveClient.java (2)
M src/org/exist/launcher/SplashScreen.java (32)

-- Patch Links --

https://github.com/eXist-db/exist/pull/288.patch
https://github.com/eXist-db/exist/pull/288.diff


Reply to this email directly or view it on GitHub:
#288

@ljo
Copy link
Member Author

ljo commented Aug 5, 2014

Yes, whatever you put in product version on build will be there eg
project.version=2.2-RC2
git.commit=094ff87831d757befece1521190819d84006ecf5

and it will be shown here.

dizzzz added a commit that referenced this pull request Aug 6, 2014
…her-spash-screen

Adding product-version (and git commit ID) to launcher spash screen
@dizzzz dizzzz merged commit c033e92 into eXist-db:develop Aug 6, 2014
@ljo ljo deleted the feature/add-product-version-to-launcher-spash-screen branch August 6, 2014 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants