Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extraneous logging of stack traces #3140

Merged
merged 2 commits into from Dec 6, 2019
Merged

Remove extraneous logging of stack traces #3140

merged 2 commits into from Dec 6, 2019

Conversation

adamretter
Copy link
Member

No description provided.

@adamretter adamretter added this to the eXist-5.1.1 milestone Dec 4, 2019
@adamretter adamretter requested a review from a team December 4, 2019 19:22
@adamretter adamretter added the bug issue confirmed as bug label Dec 4, 2019
line-o
line-o reviewed Dec 4, 2019
View reviewed changes
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this change, if e (the stack trace) does not contain any useful extra information, not contained in the error message.

joewiz
joewiz approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@joewiz joewiz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take @line-o's comment as approval by a core developer. Merging to facilitate inclusion in 5.1.1.

@joewiz joewiz merged commit bbd9ebc into eXist-db:develop Dec 6, 2019
@adamretter adamretter deleted the hotfix/connection-issue-quiet-log branch March 20, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@line-o line-o line-o left review comments

@joewiz joewiz joewiz approved these changes

Assignees
No one assigned
Labels
bug issue confirmed as bug
Projects
None yet
Milestone
eXist-5.1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamretter @joewiz @line-o