Fix: enabling SSL via commandline arguments, when doing a backup/restore

[MisterZurk0n]

A small fix for the Backup.Main, which enables the user to connect to a remote eXist server via SSL

Closes #3434

[adamretter]

Hi @MisterZurk0n thanks for your PR :-)

I made a small additional commit...

Previously, you had it set to take the SSL setting as part of the options argument i.e. -ossl-enable=true.

Instead, I modified it to have its own argument in the same was as the Java Admin Client. You can now use either --use-ssl or the shorter -S to enable SSL.

I tested this by running the backup over SSL using the following command:

$ bin/backup.sh --use-ssl -u admin -ouri=xmldb:exist://localhost:8443/exist/xmlrpc -b /db

NOTE: You still have to set the correct port, otherwise it will attempt SSL to port 8080.

If you are happy with this, let me know and I will get it merged.

[MisterZurk0n]

That is way better than my approach, you can merge this. I was too focused on the commandline example which was given in the issue description. Thank you for your help!

[adamretter]

@dizzzz I just rebased. Assuming that CI passes (excl. Java 14), then we should be good to go :-)

[joewiz]

Oops, unless this flag was already in the documentation, the PR should probably have been labelled as "needs documentation" and held until documentation was submitted - but luckily a user spotted this and volunteered to submit it! #3434 (comment)