Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for mail:send-email #4159

Merged
merged 8 commits into from Jan 4, 2022
Merged

Tests for mail:send-email #4159

merged 8 commits into from Jan 4, 2022

Conversation

adamretter
Copy link
Member

Closes #4156

@adamretter adamretter added the enhancement new features, suggestions, etc. label Jan 3, 2022
@adamretter adamretter added this to the eXist-5.4.0 milestone Jan 3, 2022
dizzzz
dizzzz requested changes Jan 4, 2022
View reviewed changes
Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing dependency?

Error: Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:analyze-only (analyze) on project exist-mail: Dependency problems found -> [Help 1]

@duncdrum
Copy link
Contributor

duncdrum commented Jan 4, 2022

see #4126 i restarted the Test servers, looks indeed like a missing dependency

@adamretter
Copy link
Member Author

@dizzzz @duncdrum Should be fixed now.

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2022 •
edited

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 26 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dizzzz dizzzz merged commit d52c1ad into eXist-db:develop Jan 4, 2022
@dizzzz dizzzz mentioned this pull request Jan 5, 2022
Closed
@adamretter adamretter deleted the test/mail-module branch January 6, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizzzz dizzzz dizzzz approved these changes

@duncdrum duncdrum Awaiting requested review from duncdrum

Assignees
No one assigned
Labels
enhancement new features, suggestions, etc.
Projects
None yet
Milestone
eXist-5.4.0
Development

Successfully merging this pull request may close these issues.

[feature] add int test for mail module
3 participants
@adamretter @duncdrum @dizzzz