fn:generate-id must provide unique IDs for unique Nodes

[adamretter]

Closes #4150

[martin-honnen]

I am wondering, however, whether the new value containing colons, if I read the code right, returns a valid xs:ID value. The function's spec says "The returned identifier must consist of ASCII alphanumeric characters and must start with an alphabetic character.". Not quite sure whether a colon : is allowed there and whether I read the Java code generating the id correctly, but it seems to do nodeImplementationType + ":" + docId + ":" + nodeId, i.e. concatenate the three parts with colons.

[adamretter]

@martin-honnen You are right of course! Somehow I missed that bit when reading the spec. I have now pushed a commit and tests which correct that.

[dizzzz]

I have a question, inline; not sure if I understand the tests, fully;
if I am... why the test results? are these reliable?

[adamretter]

if I am... why the test results? are these reliable?

@dizzzz There was a mistake in the test, but the test still passed because the missing document evaluated to an empty-sequence, which was valid for all of the tests I made.

I have now fixed the missing document, and added a guard to ensure all documents are present.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication