New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.x.x] Fix XML Catalogue Resolution #4320
Merged
dizzzz
merged 7 commits into
eXist-db:develop-4.x.x
from
evolvedbinary:4.x.x/hotfix/xml-catalogue-resolution
Apr 14, 2022
Merged
[4.x.x] Fix XML Catalogue Resolution #4320
dizzzz
merged 7 commits into
eXist-db:develop-4.x.x
from
evolvedbinary:4.x.x/hotfix/xml-catalogue-resolution
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stXMLCatalogResolver
line-o
reviewed
Apr 7, 2022
exist-core/src/main/java/org/exist/xquery/functions/validation/Jaxp.java
Outdated
Show resolved
Hide resolved
Happy to help. Don't hesitate to reach out if you have questions. I'll try to remember to let you know when I implement the "SaxProducer" interface you proposed for the resolver and Jing. |
@adamretter do you plan to port this to 6.x.x ? I would like us to get this in. |
@line-o Yes, I will shortly send ports for 5.x.x and 6.x.x |
adamretter
changed the title
Fix XML Catalogue Resolution
[4.x.x] Fix XML Catalogue Resolution
Apr 8, 2022
This was referenced Apr 11, 2022
dizzzz
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using a custom OASIS Catalog Resolver, unfortunately this did not correctly resolve files in the catalogue that had relative path.
This replaces our custom code with @ndw's excellent xmlresolver.org library.
Many thanks to Norman Walsh for his help with this.