Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x.x] Fix XML Catalogue Resolution #4320

Conversation

adamretter
Copy link
Member

Previously we were using a custom OASIS Catalog Resolver, unfortunately this did not correctly resolve files in the catalogue that had relative path.

This replaces our custom code with @ndw's excellent xmlresolver.org library.

Many thanks to Norman Walsh for his help with this.

@adamretter adamretter added the bug issue confirmed as bug label Apr 7, 2022
@adamretter adamretter added this to the eXist-4.10.1 milestone Apr 7, 2022
@ndw
Copy link

ndw commented Apr 7, 2022

Happy to help. Don't hesitate to reach out if you have questions.

I'll try to remember to let you know when I implement the "SaxProducer" interface you proposed for the resolver and Jing.

@line-o
Copy link
Member

line-o commented Apr 7, 2022

@adamretter do you plan to port this to 6.x.x ? I would like us to get this in.

@adamretter
Copy link
Member Author

@line-o Yes, I will shortly send ports for 5.x.x and 6.x.x

@adamretter adamretter changed the title Fix XML Catalogue Resolution [4.x.x] Fix XML Catalogue Resolution Apr 8, 2022
@dizzzz dizzzz merged commit dc9d70c into eXist-db:develop-4.x.x Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issue confirmed as bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants