Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x.x] Improve out-of-scope detection for binary variables #4410

Merged
merged 4 commits into from May 30, 2022
Merged

[5.x.x] Improve out-of-scope detection for binary variables #4410

merged 4 commits into from May 30, 2022

Conversation

adamretter
Copy link
Member

Forward port of #4408

@adamretter adamretter added the bug issue confirmed as bug label May 25, 2022
@adamretter adamretter requested a review from a team May 25, 2022 17:24
reinhapa
reinhapa requested changes May 29, 2022
View reviewed changes
Copy link
Member

@reinhapa reinhapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some spots, that may need a second look....

exist-core/src/main/java/org/exist/dom/persistent/AVLTreeNodeSet.java Show resolved Hide resolved
exist-core/src/main/java/org/exist/dom/persistent/VirtualNodeSet.java Outdated Show resolved Hide resolved
exist-core/src/main/java/org/exist/dom/persistent/VirtualNodeSet.java Outdated Show resolved Hide resolved
exist-core/src/main/java/org/exist/xquery/RangeSequence.java Show resolved Hide resolved
exist-core/src/main/java/org/exist/xquery/functions/array/ArrayType.java Outdated Show resolved Hide resolved
exist-core/src/main/java/org/exist/xquery/functions/array/ArrayType.java Outdated Show resolved Hide resolved
exist-core/src/main/java/org/exist/xquery/functions/map/MapType.java Outdated Show resolved Hide resolved
exist-core/src/main/java/org/exist/xquery/functions/map/MapType.java Outdated Show resolved Hide resolved
exist-core/src/main/java/org/exist/xquery/value/SubSequence.java Show resolved Hide resolved
exist-core/src/main/java/org/exist/xquery/value/SubSequence.java Show resolved Hide resolved
@adamretter
Copy link
Member Author

Thanks @reinhapa I have pushed an additional commit which I think addresses the issues that you found.

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
21.9% 21.9% Duplication

@reinhapa reinhapa merged commit cbc04e9 into eXist-db:develop-5.x.x May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinhapa reinhapa reinhapa approved these changes

Assignees
No one assigned
Labels
bug issue confirmed as bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamretter @reinhapa