Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow xs:string to be cast as xs:QName #4439

Merged
merged 2 commits into from Jun 10, 2022

Conversation

rhubner
Copy link
Contributor

@rhubner rhubner commented Jun 9, 2022

Fix #3390

This open source contribution to the eXist-db project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov/

@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@adamretter adamretter added this to the eXist-6.0.2 milestone Jun 10, 2022
@adamretter adamretter added the bug issue confirmed as bug label Jun 10, 2022
@adamretter adamretter requested a review from dizzzz June 10, 2022 13:32
declare
%test:assertFalse
function t:castable-test() {
"0" castable as xs:QName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesnt this throw an exception in stead of false? Or the xpathexception cought generic?

@dizzzz dizzzz merged commit 0effcf3 into eXist-db:develop Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issue confirmed as bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] xs:QName castable as returns incorrect results
3 participants