[4.x.x] Prevent OutOfMemory on JDK 17 when loading EXPath Modules #4617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ever LamdaMetafactory cannot cross classloader boundaries. As only EXPath Repo classes are now loaded by the EXistClassLoader everything else is loaded by a URLClassLoader (via AppAssemblerBooter), we have to use reflection instead of invokeDynamic to load EXPath Jar Modules Conflict manually resolved: exist-core/src/main/java/org/exist/xquery/XQueryContext.java
|
@ohumbel Thanks for the contribution, this is very interesting. Do you believe that this also occurs in eXist-db 5 and 6? |
adamretter
changed the title
@adamretter We tested both eXist-db 4 and 6. If the commit already is on 5 (which I did not check), we could assume the problem is not there. |
reinhapa
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use 4.x.x with custom
org/exist/xquery/Functions.This works fine on JDK 11.
As soon as we use JDK 17, we get OutOfMemory in the Non-heap region (Lambdas from
org/exist/xquery/Function).6 does not show the problem.
If we pick the commit:
4ec61b0
([bugfix] EXPath Repo classes must be instantiable via reflection, however LamdaMetafactory cannot cross classloader boundaries. As only EXPath Repo classes are now loaded by the EXistClassLoader everything else is loaded by a URLClassLoader (via AppAssemblerBooter), we have to use reflection instead of invokeDynamic to load EXPath Jar Modules)
from develop, the OutOfMemory goes away.
Forensics done together with @reinhapa.