Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to eXist-db regarding circular imports #4996

Merged
merged 18 commits into from
Oct 15, 2023

[bugfix] Allow for one ExistXqueryRegistry per BrokerPool instance

78c34d2
Select commit
Loading
Failed to load commit list.
Merged

Fixes to eXist-db regarding circular imports #4996

[bugfix] Allow for one ExistXqueryRegistry per BrokerPool instance
78c34d2
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Oct 14, 2023 in 0s

18 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 4
- Added 18
           

Complexity increasing per file
==============================
- extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/AbstractClassIntegrationTest.java  1
- extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/AbstractIntegrationTest.java  3
- extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/SelfImportCircularDependencyIntegrationTest.java  1
- extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/MediaTypeIntegrationTest.java  1
- extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java  3
- extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/AbstractInstanceIntegrationTest.java  1
- extensions/exquery/restxq/src/main/java/org/exist/extensions/exquery/restxq/impl/RestXqServiceRegistryManager.java  1
         

Clones added
============
- exist-core/src/test/java/org/exist/xquery/ImportModuleTest.java  26

See the complete overview on Codacy

Annotations

Check warning on line 2497 in exist-core/src/main/java/org/exist/xquery/XQueryContext.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/xquery/XQueryContext.java#L2497 

The method 'importModule(String, String, AnyURIValue)' has an NPath complexity of 11340, current threshold is 200

Check warning on line 2573 in exist-core/src/main/java/org/exist/xquery/XQueryContext.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/xquery/XQueryContext.java#L2573 

The method 'importModuleFromLocation(String, String, AnyURIValue)' has an NPath complexity of 896, current threshold is 200

Check warning on line 2707 in exist-core/src/main/java/org/exist/xquery/XQueryContext.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/xquery/XQueryContext.java#L2707 

The method 'compileModule(String, String, String, Source)' has an NPath complexity of 256, current threshold is 200

Check notice on line 35 in extensions/exquery/restxq/src/main/java/org/exist/extensions/exquery/restxq/impl/RestXqServiceRegistryManager.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/main/java/org/exist/extensions/exquery/restxq/impl/RestXqServiceRegistryManager.java#L35 

Unused import - java.util.HashMap.

Check notice on line 62 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java#L62 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 64 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java#L64 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 65 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java#L65 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 66 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java#L66 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 68 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java#L68 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 83 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java#L83 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 97 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java#L97 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 107 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java#L107 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 113 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java#L113 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 114 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java#L114 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 117 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java#L117 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 119 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java#L119 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 121 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/LibraryCircularDependencyIntegrationTest.java#L121 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check warning on line 72 in extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/SelfImportCircularDependencyIntegrationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

extensions/exquery/restxq/src/test/java/org/exist/extensions/exquery/restxq/impl/SelfImportCircularDependencyIntegrationTest.java#L72 

JUnit tests should include assert() or fail()
View more details on Codacy Production