-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] No version for EXPath Crypto dependency #8
Comments
I have also just tested the following which also appears to fail:
I get the following error:
I believe the additional error in this comment may instead be related to eXist-db/exist#4901 |
The latest EXPath crypto module v6.0.1
Definitely. This was planned once the crypto-module renaming and re-versioning would settle. I guess crypto-6.0.1 is stable for long enough now.
Yes. The library had to deal with this mess since crypto-0.3.x |
I had installed a test system (that I no longer have access to) with exactly these versions, and I have not seen the error you posted. Quite frankly, I have no idea. I maintain other systems that run exist v6.2.0 and crypto v6.0.1. Unfortunately, they forked existdb-saml and introduced an incompatble version numbering. But a quick look at the code suggests the code that does crypto import and crypto usage is not different from existdb-saml v1.6.x. existdb-saml 1.6.x is expected to work with exist6 and crypto-6.0.1. I very vaguely remember a confusing error like this when I installed and upgraded various crypto-lib versions in a row for testing. I suspected some confusion with package management, restarted with a fresh exist, and never bothered to debug this. |
@chakl Thanks, To clarify... would that explicitly be eXist-db 6.0.0 then, or if not, which newer version please? |
I'd say >=5.3.0, you know that release better than me |
I had thought that expath-crypto-module 6.0.1 required eXist 6, but I see from the pom that the dependency is actually eXist 5.3.0+: https://github.com/eXist-db/expath-crypto-module/blob/main/pom.xml#L97. But then again this issue says there are problems with 5.3.0: eXist-db/expath-crypto-module#64. Hmm... |
Hmm.. when following your link eXist-db/expath-crypto-module#64, it seems to refer to tests with exist v5.4.x versions. Tests failed with I don't think this 5.4.x release was put into production anywhere. |
Closing this. Not a bug. Not specifying a @adamretter If you have more evidence of incorrect behavior, please open another issue. |
Agreed.
Well not always actually! It depends on which version of eXist-db you have. The Crypto module has a minimum supported version of eXist-db too! So the "latest" version of the Crypto module for eXist-db 6.1.0 will not be the same as the latest version of the Crypto module for previous versions of eXist-db. So for example. The existdb-saml module will almost certainly not work on eXist-db 3.2.0 with the version of the Crypto module which supports eXist-db 3.2.0. That is to say that the following from the existdb-saml module's <dependency package="http://expath.org/ns/crypto"/>
<dependency processor="http://exist-db.org" semver-min="3.2.0"/> |
@adamretter I hear you. As stated in the last Close these issues will be addressed in an upcoming maintenance release.
Probably not, but you're fabricating a fictional scenario. You may want to hire consultants who know eXist-db and SAML to address this, if very old eXist-db need to be modernized. Re-Closing |
I am afraid I don't understand. How is this fictional?
We will send a PR to fix this problem, and that will close this issue. |
The existdb-saml EXPath Package (including the latest version 1.6.3) does not declare the version of the EXPath Crypto module that it depends on.
The
expath-pkg.xml
in the XAR file, only contains this:The dependency on
http://expath.org/ns/crypto
should declare at least asemver-min
.There have been lots of differing version of the EXPath Crypto module (published for eXist-db), including crypto versions:
6.0.1
,6.0.0
,5.3.0
,1.0.0
,0.7
,0.6
,0.5
,0.3.5
, and0.3.4
.The
existdb-saml
module declares that it requires eXist-db version 3.2.0 or later. The version of EXPath Crypto for eXist-db 3.2.0 (i.e. 0.3.5) however does not appear to work with theexistdb-saml
module on eXist-db 6.1.0. See https://exist-db.org/exist/apps/public-repo/packages/crypto?eXist-db-min-version=3.2.0Questions
The text was updated successfully, but these errors were encountered: