[WIP] sso-users #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joewiz
reviewed
May 1, 2023
| @@ -87,8 +87,8 @@ declare function exsaml:info() { | |||
| : @param relaystate this is the path component of the resource that the user | |||
| : initially requested, so that she gets sent there after SAML auth. | |||
| :) | |||
| declare function exsaml:build-authnreq-redir-url($relaystate as xs:string) { | |||
| let $log := exsaml:log("info", "building SAML auth request redir-url; relaystate: " || $relaystate) | |||
| declare function exsaml:build-authnreq-redir-url($relayurl as xs:string, $realm as xs:string) { | |||
There was a problem hiding this comment.
This is a breaking change for any app that relies on exsaml:build-authnreq-redir-url#1 (the original arity-1 version of this function). For backwards compatibility, would it be possible to retain the arity-1 version of this function? If that's not possible, this PR would to be released in a new major version of the package.
There was a problem hiding this comment.
@joewiz I was planning to do exactly that, for backwards compatibility
There was a problem hiding this comment.
Great! Hopefully that will allow my existing apps that use existdb-saml (e.g., hsa, guides, hma) to continue working without modification. Of course, if there's an important breaking change, we can always change the other apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preview of SAML SSO changes to support multiple auth realms.
While there, reduce code surface inside privileged system:as-user() calls.