Add handling for EXPath Package SemVer Templates #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version is maintained in the pom.xml
It’s of little relevance
joewiz
force-pushed
the
simplify-coerce-add-templates
branch
from
b72ec44
to
bc75cc5
Compare
… and move anonymous functions into utility functions
… and call semver:coerce as soon as semver regex fails
… to be next to the other comparison functions
joewiz
force-pushed
the
simplify-coerce-add-templates
branch
5 times, most recently
from
271fe89
to
0ca898e
Compare
… Rename as semver:serialize-parsed to match other *-parsed functions that are variants of functions that take unparsed version strings
joewiz
force-pushed
the
simplify-coerce-add-templates
branch
2 times, most recently
from
adafedd
to
7b64a49
Compare
joewiz
force-pushed
the
simplify-coerce-add-templates
branch
from
7b64a49
to
bc2d9b9
Compare
joewiz
force-pushed
the
simplify-coerce-add-templates
branch
from
c0e6349
to
2ed37ea
Compare
joewiz
force-pushed
the
simplify-coerce-add-templates
branch
from
2ed37ea
to
8d4f94d
Compare
… And make sort-parsed a public function
joewiz
force-pushed
the
simplify-coerce-add-templates
branch
from
8d4f94d
to
76ff279
Compare
This was referenced Dec 31, 2022
|
Quite the piece of work @joewiz. Nicely done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling for resolving EXPath Package SemVer Templates - a feature needed to support the forthcoming fix to eXist-db/public-repo#72. Tests have been added for the new functions.
It also significantly simplifies the implementation of
semver:coerce- by adding a new regex that can flexibly capture groups. All existing tests involving coercion pass.It also adds missing variants of
semver:eq#3and new variants of all of the comparison functions for working directly with parsed version maps (e.g.,semver:eq-parsed), to avoid needless parsing/serializing when performing comparisons of already-parsed versions.It also deprecates
semver:compare#1, renaming it assemver:compare-parsed, to follow the pattern of appending-parsedto the names of functions that handle parsed SemVer version maps.