Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add monolog 3 support #18

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

lapie002
Copy link
Contributor

@lapie002 lapie002 commented Mar 3, 2023

Description

update package to support monolog up to version 3.x

@lapie002 lapie002 self-assigned this Mar 3, 2023
@lapie002 lapie002 marked this pull request as draft March 6, 2023 15:51
@lapie002 lapie002 marked this pull request as ready for review March 6, 2023 16:03
@lapie002
Copy link
Contributor Author

lapie002 commented Mar 6, 2023

@xel1045 etrangement j'ai du revert mes modifs , je voulais utiliser :

mais ca passe pas pour certaine version de php - j ai du revert cette modif là.

Screenshot 2023-03-06 at 11 08 41 AM

Copy link
Member

@xel1045 xel1045 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai ajouté un test e2e pour s'assurer que les message s'envoient bel et bien. Tout semble être beau pour toutes les versions de PHP et de Laravel, alors ça me satisfait.

Je vais merger le tout!

@xel1045 xel1045 merged commit 8ca84d5 into feature/laravel-10-support Mar 9, 2023
@xel1045 xel1045 deleted the feature/monolog-3-support branch March 9, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants