Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XmlRpc.SetApiVersion doesen't exist in all script modes #243

Closed
3 tasks
oliverde8 opened this issue Feb 2, 2018 · 0 comments
Closed
3 tasks

XmlRpc.SetApiVersion doesen't exist in all script modes #243

oliverde8 opened this issue Feb 2, 2018 · 0 comments
Assignees
@oliverde8
Labels
1. Bug 😭 2. High 👍 Priority
Milestone
alpha-2

Comments

@oliverde8
Copy link
Member

I'm reporting a Bug

We have a call to XmlRpc.SetApiVersion hard coded in eXpansion. It seems this method doesn't exist in all script modes.

  • Validate that it doesn't exist.
  • Move the code in a data provider.
  • Have a try catch as it's an optional code for some scripts only
@oliverde8 oliverde8 self-assigned this Feb 2, 2018
@oliverde8 oliverde8 modified the milestones: beta-1, alpha-2 Feb 2, 2018
oliverde8 added a commit that referenced this issue Feb 3, 2018
@oliverde8
#243 - Fixed issue with eXpansion crashing if script mode didn't have…
53375e8 
… 'setApiVersion' method.
oliverde8 added a commit that referenced this issue Feb 3, 2018
@oliverde8
Merge pull request #244 from eXpansionPluginPack/fix-243
5c70713 
#243 - Fixed issue with eXpansion crashing if script mode didn't have…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverde8 oliverde8

Labels
1. Bug 😭 2. High 👍 Priority
Projects
None yet
Milestone
alpha-2
Development

No branches or pull requests
1 participant
@oliverde8