Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fixed #11

Open
wants to merge 83 commits into
base: master
Choose a base branch
from
Open

WIP fixed #11

wants to merge 83 commits into from

Conversation

sandsmark
Copy link

@sandsmark sandsmark commented Jan 3, 2021

included the english translation, ported away from directx stuff (uses sfml for everything), switched to embedding the resources (images and sounds) so it doesn't have to be run from the bin directory, and some other stuff (translating stuff in the source from german to english etc.)

seems to work well enough here on linux, but it's still a bit messy

@eXpl0it3r
Copy link
Owner

Haven't really commented on this so far, as you've been making a lot of updates still.

Awesome work! 🙂

Obviously it's kind of hard to review this huge PR, so I wonder:

  • What are the main changes you've been doing?
  • What are your future plans?

@sandsmark
Copy link
Author

Obviously it's kind of hard to review this huge PR, so I wonder:

Yeah, I went a bit overboard. :-P

I guess the easiest is just to review the new code as is or something.

  • What are the main changes you've been doing?

Basically just clean everything up. Translated most of the code (and a lot of the comments) from german to english, porting all the graphics stuff from directx to sfml, replaced a lot of windows-specific APIs with cross platform stuff, replaced a lot of defines with enums, cleaning invalid memory stuff, fixed english text in the UI, replaced the loading of game assets (graphics and sound) from the directory the binary is run from with baking them into the executable itself (so you just need the executable to run it, i. e. standalone).

And just a lot of cleaning up the code in general.

  • What are your future plans?

Replacing all the global state with proper classes is probably the next thing I want to do. And in general just making the codebase "modern" and a bit more future proof. I like the game. :-)

FWIW, I made a pkgbuild for archlinux as well and put it on the AUR: https://aur.archlinux.org/packages/schiffbruch-git

@SimonHeimberg
Copy link
Contributor

I was able to compile with cmake on linux after I fixed above problem. Actually this is the same problem as is reported by AppVeyor. A big success for me, since I am not used to compiling.

The game is playable but has some bugs:

  • when starting a new game, I still have the material from the previous game. Work around: quit the game, delete save.date (in the current working directory), start the game
  • there is no mark on the map
  • disabling water animation hides fields
  • numbers (after night when sleeping outside) are outside paper and stay
  • start animation often does not play properly on game start. Moving the mouse shows it. It does more likely when starting a new game.
  • when landing with the boat in an edge of the corner, the boat sometimes lands on the wrong edge and a tree is removed or even the river delta (beach with river)
  • man walked once out over the water, before leaving the game (by ESC or btn)

thanks for porting this game to all involved

@eXpl0it3r eXpl0it3r mentioned this pull request Oct 20, 2022
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants