Merge pull request #8 from eadwinCode/factory_fi

Factory Refactor
eadwinCode · Sep 16, 2023 · ffe8910 · ffe8910
2 parents 7e47fbf + 5cbfda6
commit ffe8910
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/ninja_schema/orm/factory.py b/ninja_schema/orm/factory.py
@@ -14,9 +14,7 @@
     from .model_schema import ModelSchema
     from .schema import Schema
 
-__all__ = [
-    "SchemaFactory",
-]
+__all__ = ["SchemaFactory"]
 
 
 class SchemaFactory:
@@ -40,6 +38,7 @@ def create_schema(
         fields: Optional[List[str]] = None,
         exclude: Optional[List[str]] = None,
         skip_registry: bool = False,
+        optional_fields: Optional[Union[str, List[str]]] = None,
     ) -> Union[Type["ModelSchema"], Type["Schema"], None]:
         from .model_schema import ModelSchema
 
@@ -49,7 +48,7 @@ def create_schema(
             raise ConfigError("Only one of 'include' or 'exclude' should be set.")
 
         schema = registry.get_model_schema(model)
-        if schema:
+        if schema and not skip_registry:
             return schema
 
         model_config_kwargs = {
@@ -59,6 +58,7 @@ def create_schema(
             "skip_registry": skip_registry,
             "depth": depth,
             "registry": registry,
+            "optional": optional_fields,
         }
         cls.get_model_config(**model_config_kwargs)  # type: ignore
         new_schema = (