Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-76696 Use senna for form to avoid multiple submits #1322

Closed
wants to merge 1 commit into from
Closed

LPS-76696 Use senna for form to avoid multiple submits #1322

wants to merge 1 commit into from

Conversation

ricardocousolr
Copy link

@ricardocousolr ricardocousolr commented Dec 27, 2017 •
edited by ealonso

Hi @ealonso. This is fix for a customer. After having talked to Chema Balsas, allowing senna for the forms was regarded as the best option. I'll be on holidays but Antonio Ortega has all the context if you have any questions. Thanks!

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@ricardocousolr
Copy link
Author

ci:test

@liferay-continuous-integration
Copy link
Collaborator

Pull request test invoked at http://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest(master).

@liferay-continuous-integration
Copy link
Collaborator

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

@ricardocousolr

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/lpkg-override-jdk8
Job Results:

0 Tests Passed.
1 Test Failed.

  1. AXIS_VARIABLE=0,label_exp=!master #186765
        [junit] Running com.liferay.portal.log.assertor.PortalLogAssertorTest
    [junit] Testsuite: com.liferay.portal.log.assertor.PortalLogAssertorTest
    [junit] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.275 sec
    [junit] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.275 sec
    [junit] 
    [junit] Testcase: testScanOSGiLog(com.liferay.portal.log.assertor.PortalLogAssertorTest):	FAILED
    [junit] 
    [junit] Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1514404267652.log:
    [junit] 
    [junit] 
    [junit] junit.framework.AssertionFailedError: 
    [junit] Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1514404267652.log:
    [junit] 
    [junit] 
    [junit] 	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog(PortalLogAssertorTest.java:82)
    [junit] 
    [junit] 
    [junit] Test com.liferay.portal.log.assertor.PortalLogAssertorTest FAILED
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:240: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1063: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1065: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:10332: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3583: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3692: 
     [echo] exec returned: 134
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:4046: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:4187: Unable to find startup message after 30 minutes.
     [echo] ${jstack.output}
      [get] Getting: http://test-1-17/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/186765//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20171227202057075.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20171227202057075.txt

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 3 hours 9 minutes 26 seconds 790 ms

Base Branch:

Branch Name: master
Branch GIT ID: 8a42521c67863556040b1446d010054c979c871e

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 2309d316405e0b57b735529ebb8d2ebfc21e6c03

109 out of 121 jobs PASSED

12 Failed Jobs:

109 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    109 Jobs Passed.
    12 Jobs Failed.

         [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-17.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/186766/. SUCCESS
     [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/207242/. SUCCESS
     [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-18.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/205463/. SUCCESS
     [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-16.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/190256/. SUCCESS
     [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-22.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/50582/. SUCCESS
     [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-9.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/179283/. SUCCESS
     [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-12.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/127158/. SUCCESS
     [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/207243/. SUCCESS
     [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-13.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/173760/. SUCCESS
     [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-16.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/190255/. SUCCESS
     [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-9.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/179284/. FAILURE
     [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-18.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/205464/. SUCCESS
     [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-8.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/154668/. SUCCESS
     [echo] 'test-portal-acceptance-pullrequest-batch(master)' completed at https://test-1-22.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/50581/. SUCCESS
     [echo] Caching GitHub message
  6. ...

@ealonso
Copy link
Owner

ealonso commented Dec 28, 2017

Just started reviewing :)

:octocat: Sent from GH.

@ealonso
Copy link
Owner

ealonso commented Dec 28, 2017

Pull request submitted to brianchandotcom#53976.

:octocat: Sent from GH.

@ealonso ealonso closed this Dec 28, 2017
@ealonso ealonso mentioned this pull request Dec 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ricardocousolr @liferay-continuous-integration @ealonso