New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-101058 As a site admin it should be possible to create content sets based on keyword searches #2533
Conversation
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
ci:test |
@ealonso while the above is functional there is a coupld of details that I think can still use some work:
|
2a21d8e
to
68a4c75
Compare
ci:stop |
ci:test |
❌ ci:test - 0 out of 1 jobs passed in 17 minutes 10 seconds 282 msClick here for more details.Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private 1 Failed Jobs:For more details click here.Failures unique to this pull:For upstream results, click here. |
Just started reviewing :) |
Hey @rotty3000, After reviewing your pull, I've see some improvements that we should take into account to merge it into the product.
Could you please take a look at it? if you don't have enough time, I can take care of it but I don't have enough time at this moment, so it should wait a couple of days. Regards, cc: @JorgeFerrer |
68a4c75
to
cea5c0d
Compare
hey @ealonso please see updated. I think this probably covers your comments. |
Oh, and I also reflected the changes directly in the Asset Publisher portlet as well. So the logic in both places where the Filter builder is used are the same. |
Just started reviewing :) |
…neAdapterClusterRequestTest.testExecuteHealthClusterRequest - Elastic default number of shards is now 1 https://issues.liferay.com/browse/LPS-101266
…neAdapterSnapshotRequestTest.testCreateSnapshot - Default number of shards is 1 https://issues.liferay.com/browse/LPS-101266
…torTest.testIndexRequestTranslation - Update create index JSON https://issues.liferay.com/browse/LPS-101266
…st1PrimaryShardByDefault - Set initial master node https://issues.liferay.com/browse/LPS-101266
…il LPS-100673 is side ported to ES7 https://issues.liferay.com/browse/LPS-101266
…less of order, for scenarios where all documents score the same https://issues.liferay.com/browse/LPS-101266
…d field (e.g. the `*<substring>*` construct) will always score 1.0 leading to indeterministic order of results on some search engine versions. https://issues.liferay.com/browse/LPS-101266
…fused as an error.
…e when new localization does not exist" This reverts commit e0f5e6f.
… gets updated in edition/insertion)
…ts based on keyword searches
cea5c0d
to
faab48f
Compare
Pull request submitted to brianchandotcom#79223. |
Pull request submitted to brianchandotcom#79274. |
Pull request submitted to brianchandotcom#79276. |
No description provided.