Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade node to 22 and storybook to v8 #371 #413

Merged
merged 2 commits into from
May 19, 2024

Conversation

Yedidyar
Copy link
Contributor

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emoji-picker-react ❌ Failed (Inspect) May 19, 2024 10:17pm

@Yedidyar
Copy link
Contributor Author

Yedidyar commented May 17, 2024

@ealush, I changed the Node version to 22 and upgraded Storybook to v8. We have some things to improve regarding deprecation and other issues, but I think this PR is big enough 😃

The Storybook is running, and it built successfully on my machine. I am not so familiar with the project, so double-checking would be great.

@ealush
Copy link
Owner

ealush commented May 19, 2024

Thank you @Yedidyar for working to improve EPR! I tested this locally, and even published an RC version to NPM (4.9.3-rc.1) and it seems to be working fine.

Since there's no functionality change, I will publish it as a patch. Thanks again!

@ealush ealush merged commit 2b6d4a8 into ealush:master May 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants