"Don't show again" on debug log warning doesn't work

[roblourens]

• Enable debug logging
• Use gitlens for awhile
• Get this notification
  
• Click "Don't show again"
• But I know I've seen this multiple times.

Actually maybe it's just saved per-workspace?

[eamodio]

It's saved in user settings:

"gitlens.advanced.messages": {
	"suppressDebugLoggingWarning": true
},

I'm not sure how that would fail -- maybe settings sync?

[roblourens]

I don't have that setting but I'll check for it next time

[roblourens]

When I click "Don't show again", it doesn't add the setting

[eamodio]

@roblourens are you aware of a settings change where we are returning a proxy object rather than a normal object? That is what causes this issue -- at some point VS Code stopped returning an object from a WorkspaceConfiguration.get call and instead returns a proxy object.

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

[roblourens]

cc @sandy081

[sandy081]

Yes the API returns proxy mainly for perf reasons - so that we do not clone the complete settings tree when we give it to the extension.

[eamodio]

@sandy081 when did that change? Because that is a breaking change depending on how the object was used.

[sandy081]

3 yrs ago - microsoft/vscode#39576

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.