Slight but noticeable keyboard lag with Gitlens

[carlca]

• GitLens Version: 5.7.1
• VSCode Version: 1.18.0 Insider
• OS Version: macOS 10.13.0 High Sierra

Other extensions loaded:

PeterJausovec.vscode-docker
RomanPeshkov.go-test-outline
Wosi.omnipascal
be5invis.vscode-custom-css
christian-kohler.path-intellisense
codezombiech.gitignore
deerawan.vscode-dash
donjayamanne.githistory
donjayamanne.python
eamodio.gitlens
eg2.vscode-npm-script
emmanuelbeziat.vscode-great-icons
foxundermoon.shell-format
hars.CppSnippets
hnw.vscode-auto-open-markdown-preview
Kiteco.kite
lukehoban.Go
magicstack.MagicPython
ms-vscode.azure-account
ms-vscode.cpptools
ms-vscode.csharp
nisimiko.theme-whitehat
rogalmic.bash-debug
rubbersheep.gi

Steps to Reproduce:

1. Open VSCode and attempt to edit a .go file
2. Keyboard lag is slight but enough to be noticeable. I've tried narrowing down the culprit by disabling my extensions in turn and it seems to be Gitlens that is causing the issue.

[egamma]

@eamodio we now support to profile the extension host pls see https://github.com/Microsoft/vscode/wiki/Performance-Issues#creating-performance-profiles, that might be useful to do in such a case.

[eamodio]

I'll take a look into this. In the meantime, can you help me determine if the issue goes away for you if you systematically disable some GitLens features?

"gitlens.blame.line.enabled": false
"gitlens.codeLens.enabled": false
"gitlens.gitExplorer.enabled": false
"gitlens.statusBar.enabled": false

If turning off any (or all) of those help, it will also help me pinpoint the issue.

@egamma Yeah -- good point. The profiler was definitely my friend in helping me greatly improve the performance of the full-file blame annotations :)

[carlca]

I'll try that in an hour or so. I have to cook some food and eat first. Thanks to you and Erich for the replies!

[carlca]

It's difficult to be certain because the differences in response time are barely perceptible but I thought there was a slight speed up when I changed
"gitlens.codeLens.enabled":
to
false
I hope that helps!

[eamodio]

Thank you! I'll check it out

[eamodio]

@carlca can you try out the latest GitLens v6 alpha? I've refactored and reduce a bunch of overhead so hopefully it will resolve the lag you are seeing.

Please follow these instructions to install a pre-release. Let me know if you experience any issues -- thanks!

[carlca]

Something I forgot to mention (sorry!) is that I have been starting VSCode insiders with the arguments --args --disable-gpu . That was because otherwise, the built-in terminal window was not displaying properly. I've just tried it without those arguments and it does seem to be improved. I don't know at the moment if that can be attributed to the new alpha version, though.

[eamodio]

Are you still seeing a difference between with and without GitLens? With the new code, there will be some impact (mostly only on the first character typed into a file without any other edits -- but even so it should be very small) it should be extremely small. From profiling I don't even see any GitLens stuff anywhere near the top of the profile.

If you are still seeing issues -- can you try disabling all other extensions and capture a snapshot of the issue, following the steps here: https://github.com/Microsoft/vscode/wiki/Performance-Issues#creating-performance-profiles?

[carlca]

I’ll get back to this tomorrow. Cheers, Carl

…

On 25 Oct 2017, 17:42 +0100, Eric Amodio ***@***.***>, wrote: Are you still seeing a difference between with and without GitLens? With the new code, there will be some impact (mostly only on the first character typed into a file without any other edits -- but even so it should be very small) it should be extremely small. From profiling I don't even see any GitLens stuff anywhere near the top of the profile. If you are still seeing issues -- can you try disabling all other extensions and capture a snapshot of the issue, following the steps here: https://github.com/Microsoft/vscode/wiki/Performance-Issues#creating-performance-profiles? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[carlca]

There's a lot of different tasks on that page https://github.com/Microsoft/vscode/wiki/Performance-Issues#creating-performance-profiles .
Which tasks, in particular, should I concentrate on (don't say all of them!!)

[eamodio]

@carlca sorry - just https://github.com/Microsoft/vscode/wiki/Performance-Issues#profile-the-extension-process

[eamodio]

I'm hoping GitLens 6 (out now) resolves this. Please re-open if not.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.