Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UriConnection SSL Warning with Heartbeat option #18

Closed
thejuan opened this issue Jun 9, 2016 · 3 comments
Closed

UriConnection SSL Warning with Heartbeat option #18

thejuan opened this issue Jun 9, 2016 · 3 comments

Comments

@thejuan
Copy link

thejuan commented Jun 9, 2016

Very minor issue.
if you use UriConnection and add a heartbeat querystring option i.e. ?heartbeat=30 a warning is output "invalid ssl option: heartbeat"
The heartbeat is still set and nothing seems affected.

@eandersson
Copy link
Owner

Ah yes, I can see the bug in the code path. It is indeed a false-positive. I'll get it fixed for the next release.

@eandersson
Copy link
Owner

I probably want to re-visit this implementation at a later date, but the bug should be fixed in trunk. Thanks!

@eandersson
Copy link
Owner

Released 1.3.4 as a maintenance release with a bug fix for this warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants