-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle all channel opening within the lock #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the current conditions. My only concern, which we can roll to the 3.x work, is the LOGGER call is not deterministic and I don't like them inside lock()s unless absolutely necessary.
Yea - the logger has bitten me before. I could just change it to
|
Yea - not a lot we can do about that unfortunately without some larger changes. There are other log events as well, but I guess that most of those are on a separate thread. Nvm. I see what you meant. Good catch. I set a slack workspace up |
Erik,
Commit it. Call it done for now. I agree this is one of those situations
where the effort to make the logging "perfect" for a corner case is going
to far outweigh the benefit. Likewise, I have been bit by logging causing
a race condition due to a blocking call/task switch.
My direct email - ***@***.*** (personal, I'll see it) or
***@***.*** (it risks getting lost)
Jay
…On Mon, May 24, 2021 at 10:18 PM Erik Olof Gunnar Andersson < ***@***.***> wrote:
An exception thrown in channel.open() will still result in a successful
log message.
(Side question: Do you have a chat/discussion channel for amqpstorm other
than issue tracking?)
Yea - not a lot we can do about that unfortunately without some larger
changes. There are ton of debug messages etc within the channel.open.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#99 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABJGJXEKDMD3LCGYRUR7WDTPMJHBANCNFSM45MOAL3A>
.
|
Sounds good. The email isn't showing up, but feel free to join the Slack workspace I set up. |
Moved both the
_cleanup_channel
andreturn
under the thread lock. We can't have the channel being cleaned up before the function return, as it will result in aKeyError
, but we need to return a channel to not break the context manager.