Skip to content
This repository has been archived by the owner on Jan 1, 2023. It is now read-only.

Commit

Permalink
Merge 64582 from mainline
Browse files Browse the repository at this point in the history
Fix PR3522. It's not safe to sink into landing pad BB's.


git-svn-id: http://llvm.org/svn/llvm-project/llvm/branches/release_25@64790 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
Tanya Lattner committed Feb 17, 2009
1 parent 7fbb674 commit a751c4f
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lib/CodeGen/MachineSink.cpp
Expand Up @@ -208,6 +208,11 @@ bool MachineSinking::SinkInstruction(MachineInstr *MI, bool &SawStore) {
// If there are no outputs, it must have side-effects.
if (SuccToSinkTo == 0)
return false;

// It's not safe to sink instructions to EH landing pad. Control flow into
// landing pad is implicitly defined.
if (SuccToSinkTo->isLandingPad())
return false;

DEBUG(cerr << "Sink instr " << *MI);
DEBUG(cerr << "to block " << *SuccToSinkTo);
Expand Down
30 changes: 30 additions & 0 deletions test/CodeGen/X86/pr3522.ll
@@ -0,0 +1,30 @@
; RUN: llvm-as < %s | llc -march=x86 -stats |& not grep machine-sink
; PR3522

target triple = "i386-pc-linux-gnu"
@.str = external constant [13 x i8] ; <[13 x i8]*> [#uses=1]

define void @_ada_c34018a() {
entry:
%0 = tail call i32 @report__ident_int(i32 90) ; <i32> [#uses=1]
%1 = trunc i32 %0 to i8 ; <i8> [#uses=1]
invoke void @__gnat_rcheck_12(i8* getelementptr ([13 x i8]* @.str, i32 0, i32 0), i32 32) noreturn
to label %invcont unwind label %lpad

invcont: ; preds = %entry
unreachable

bb22: ; preds = %lpad
ret void

return: ; preds = %lpad
ret void

lpad: ; preds = %entry
%2 = icmp eq i8 %1, 90 ; <i1> [#uses=1]
br i1 %2, label %return, label %bb22
}

declare void @__gnat_rcheck_12(i8*, i32) noreturn

declare i32 @report__ident_int(i32)

0 comments on commit a751c4f

Please sign in to comment.