Add password for OTA upload to LittleFS #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Password capability added to plug-in. If none required simply leave it empty. Use this plug-in only, if you had enough of flashing stupid temporary sketches without password, just to upload the file system and then flash again the final sketch. The dialog box will show up every time, even there is no password required (sorry, can't be avoided without modifying too much).
If a password is required to upload LittleFS via OTA, it can be entered now. Downside is, that the dialog box shows up every time. Simply leave it empty, if no password is required. In case you don't like this "extra" effort, don't use this plug-in.
For ESP8266 OTA upload of LittleFS
| @@ -320,7 +321,17 @@ private void createAndUpload(){ | |||
| if(isNetwork){ | |||
| System.out.println("[LittleFS] IP : "+serialPort); | |||
| System.out.println(); | |||
| sysExec(new String[]{pythonCmd, espota.getAbsolutePath(), "-i", serialPort, "-s", "-f", imagePath}); | |||
|
|
|||
There was a problem hiding this comment.
Do you think you could actually see if an AUTH is needed before presenting the box? I understand that you're using it, but since ArduinoOTA is so insecure anyway I have a feeling that most people will not be using a password at all.
It's possible to probe the board using UDP comms (connect to ESP8266, send SPIFFS command, check for AUTH response, see espota.py), or even just call espota.py once, and if it fails then prompt for a PWD and try again.
There was a problem hiding this comment.
Very nice and simple, BTW! Just trying to make the default case the easiest/simplest for end users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dialogbox requests a password, even it may not be required. If you know, that OTA is not protected by password, leave the box empty and continue. The upload script is then called as before.
If a password is entered, the script will be executed with the -a option and the password.