Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP8266_ARDUINO_PYTHON_PATH environment var #48

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

mcspr
Copy link

@mcspr mcspr commented Mar 15, 2023

esp8266/Arduino#8886 suggestion

--- python3/python3     2019-12-29 19:28:00.000000000 +0300
+++ python3/python3     2023-03-15 20:58:40.064782893 +0300
@@ -2,5 +2,7 @@
 import os
 import sys

-args = ["env", "python3"] + sys.argv[1:];
-os.execv("/usr/bin/env", args)
+EXE = os.environ.get("ESP8266_ARDUINO_PYTHON_PATH", "python3")
+ARG = ["env", EXE] + sys.argv[1:]
+
+os.execv("/usr/bin/env", ARG)

@earlephilhower
Copy link
Owner

This seems like extreme measures for a vanishingly small number of users (1?), but it seems safe enough.

Give me a couple days to update and hand-patch the updated toolchain PR in the core with this new one.

Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request. The file type is tar.gz but your repo has a simple uncompressed .tar. I think that may cause issues. Can you do a tar zcvf to package instead?

@earlephilhower earlephilhower merged commit 1cd2ab4 into earlephilhower:master Mar 16, 2023
@mcspr mcspr deleted the override-python branch March 17, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants