Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] X to close TOC only #1

Closed
sergeevabc opened this issue Dec 15, 2016 · 7 comments
Closed

[FIXED] X to close TOC only #1

sergeevabc opened this issue Dec 15, 2016 · 7 comments
Assignees

Comments

@sergeevabc
Copy link

sergeevabc commented Dec 15, 2016

When I click X, focus is changed to #, which is beginning of the page.
Expected behaviour is to close TOC panel only.
Could you be so kind to enhance the bookmarklet thus?

@earshinov earshinov self-assigned this Dec 16, 2016
earshinov added a commit that referenced this issue Dec 16, 2016
@earshinov
Copy link
Owner

Thank you for the feedback! I am pleased to know there are users of the bookmarklet apart from myself.

It is done now. I have also put the updated code of the bookmarklet on the home page.

@sergeevabc
Copy link
Author

sergeevabc commented Dec 17, 2016

Thank you for a quick reply, @earshinov.

Alas, I cannot confirm the result meets the expectations since X still moves focus back to top (browser is Pale Moon 27.0.3). Good news is that I was lucky to find Marc Hoyois’ HTML5 outliner, which requires no additional connection to Github and generates TOC where TocIt fails (example page: yours vs that).

@sergeevabc sergeevabc changed the title X to close TOC [INCOMPLETE] X to close TOC only Dec 17, 2016
earshinov added a commit that referenced this issue Dec 17, 2016
@earshinov
Copy link
Owner

I have committed an additional fix.

If you decide to test it, please update the bookmarklet from the home page. Due to my mistake the bookmarket was served from a wrong server which cached the bookmarket forever (actually, that server still serves the version before the initial fix).

Both problems you mentioned in conjunction with HTML5 outliner may be fixed. Feel free to file issues about them if you decide to give my bookmarklet another try.

@sergeevabc
Copy link
Author

So I cleared the cache, added your bookmarklet and…

  1. Open example page.
  2. Activate bookmarklet.
  3. Jump to some item from menu.
  4. Click X to close TOC, it works now as expected.
  5. But activate bookmarket once again, then click X — nothing happens, TOC is not closed.

@earshinov
Copy link
Owner

Thanks you for the information! Sorry for a late reply, I've been a little pressed for time lately. It should be working now (but make sure to clear your browser's cache before testing).

@sergeevabc sergeevabc changed the title [INCOMPLETE] X to close TOC only [FIXED] X to close TOC only Dec 21, 2016
@sergeevabc
Copy link
Author

sergeevabc commented Dec 21, 2016

Now X closes TOC’s panel as expected, that’s great.
Yet table itself could not called truly comprehensive as I proved earlier (see screenshots once again).

@earshinov
Copy link
Owner

@sergeevabc I've created a separate issue for this: #3 and committed a fix. Please check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants