-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXED] X to close TOC only #1
Comments
Thank you for the feedback! I am pleased to know there are users of the bookmarklet apart from myself. It is done now. I have also put the updated code of the bookmarklet on the home page. |
Thank you for a quick reply, @earshinov. Alas, I cannot confirm the result meets the expectations since X still moves focus back to top (browser is Pale Moon 27.0.3). Good news is that I was lucky to find Marc Hoyois’ HTML5 outliner, which requires no additional connection to Github and generates TOC where TocIt fails (example page: yours vs that). |
I have committed an additional fix. If you decide to test it, please update the bookmarklet from the home page. Due to my mistake the bookmarket was served from a wrong server which cached the bookmarket forever (actually, that server still serves the version before the initial fix). Both problems you mentioned in conjunction with HTML5 outliner may be fixed. Feel free to file issues about them if you decide to give my bookmarklet another try. |
So I cleared the cache, added your bookmarklet and…
|
Thanks you for the information! Sorry for a late reply, I've been a little pressed for time lately. It should be working now (but make sure to clear your browser's cache before testing). |
Now X closes TOC’s panel as expected, that’s great. |
@sergeevabc I've created a separate issue for this: #3 and committed a fix. Please check it out. |
When I click X, focus is changed to #, which is beginning of the page.
Expected behaviour is to close TOC panel only.
Could you be so kind to enhance the bookmarklet thus?
The text was updated successfully, but these errors were encountered: