Memory leak in Analyzer #21
Assignees
Labels
Comments
earthgecko
added a commit
that referenced
this issue
Aug 14, 2016
- Moved trigger_alert to a multiprocessing process when the alert is smtp. This is used by smtp alerters so that matplotlib objects are cleared down and the alerter cannot create a memory leak in this manner as plt.savefig keeps the object in memory until the process terminates. Seeing as data is being surfaced and processed in the alert_smtp context, multiprocessing the alert creation and handling prevents any memory leaks in the parent. This fixes Issue #21 Memory leak in Analyzer - #21 internal ref #1558: Memory leak in Analyzer - In agent del the algorithm test objects to free the memory - Applied in both Analyzer and Mirage - Some pyflakes linting done - Reintroduced the original alert substring matching AFTER wildcard matching, to allow more flexibility - In Analyzer streamlined the Mirage metrics a bit - Added some settings vaidation in the agents Added: skyline/validate_settings.py Modified: skyline/analyzer/agent.py skyline/analyzer/analyzer.py skyline/analyzer/alerters.py skyline/mirage/agent.py skyline/mirage/mirage.py skyline/mirage/mirage_alerters.py
earthgecko
added a commit
that referenced
this issue
Aug 14, 2016
- Moved trigger_alert to a multiprocessing process when the alert is smtp. This is used by smtp alerters so that matplotlib objects are cleared down and the alerter cannot create a memory leak in this manner as plt.savefig keeps the object in memory until the process terminates. Seeing as data is being surfaced and processed in the alert_smtp context, multiprocessing the alert creation and handling prevents any memory leaks in the parent. This fixes Issue #21 Memory leak in Analyzer - #21 internal ref #1558: Memory leak in Analyzer - In agent del the algorithm test objects to free the memory - Applied in both Analyzer and Mirage - Some pyflakes linting done - Reintroduced the original alert substring matching AFTER wildcard matching, to allow more flexibility - In Analyzer streamlined the Mirage metrics a bit - Added some settings vaidation in the agents Added: skyline/validate_settings.py Modified: skyline/analyzer/agent.py skyline/analyzer/analyzer.py skyline/analyzer/alerters.py skyline/mirage/agent.py skyline/mirage/mirage.py skyline/mirage/mirage_alerters.py
|
Moved trigger_alert to a multiprocessing process when the alert is smtp. This is used by smtp alerters so that matplotlib objects are cleared down and the alerter cannot create a memory leak in this manner as plt.savefig keeps the object in memory until the process terminates. Seeing as data is being surfaced and processed in the alert_smtp context, multiprocessing the alert creation and handling prevents any memory leaks in the parent. Removed the unused but appended to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Analyzer memory leaks under certain conditions in relation to Mirage, an unused Mirage list that is being appended too but not reset and matplotlib savefig in the alerters context.
The text was updated successfully, but these errors were encountered: