Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use skyline; #12

Merged
merged 1 commit into from Jul 29, 2016
Merged

Add use skyline; #12

merged 1 commit into from Jul 29, 2016

Conversation

blak3r2
Copy link

@blak3r2 blak3r2 commented Jul 29, 2016

Prevents a ERROR 1046 (3D000) at line 16: No database selected

Prevents a ```ERROR 1046 (3D000) at line 16: No database selected```
@earthgecko
Copy link
Owner

Once again thanks Blake!

I actually wondered about having the CREATE SCHEMA in there in the first place as you could call it any name and/or collation you wanted. The deployment pattern is a concern for me as well. I did not doc how to execute or implement it exactly either, I just said look at the sql as I was not convinced of a method.

Hence this is quite a nice issue you raise as ideally if this sql was to be run, it should be able run in an idempotent manner as most people will have automation and it really helps automation if it can be run idempotently without ever doing harm.

Perhaps the specifics of the DB deployment is something that should be left in the hands of the implementor as they know best and there is a MySQL user management part that is not included as well.

So actually I am quite glad it "broke" here in a way as it needs some more thought and polishing I think, I will wrap all the things in IF NOT EXISTS too, that should almost achieve the goal.

@earthgecko earthgecko merged commit 77afa2d into earthgecko:master Jul 29, 2016
@blak3r2
Copy link
Author

blak3r2 commented Jul 29, 2016

The way if look at it is. Who cares if it's secure if noone can get it
installed. Make it easy. :)

On Friday, July 29, 2016, earthgecko notifications@github.com wrote:

Merged #12 #12.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKSn83ybjPqsUlWJorC820ueETiTRqM0ks5qaasdgaJpZM4JX2jD
.

earthgecko added a commit that referenced this pull request Jul 29, 2016
- Merged @blak3r2 patch-5 #12 to
  crucible branch
use skyline;
Modified:
skyline/skyline.sql
earthgecko added a commit that referenced this pull request Jul 29, 2016
objects - related to blak3r2:patch-5 #12
Making the skyline.sql idempotent
Modified:
skyline/skyline.sql
earthgecko added a commit that referenced this pull request Jul 29, 2016
objects - related to blak3r2:patch-5 #12
Making the skyline.sql idempotent
Modified:
skyline/skyline.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants