fix: event permission issue #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkalpana
requested review from
akurungadam and
akashkrishna619
as code owners
|
@fkalpana please follow what-is-commitlint and please update your commit message |
akashkrishna619
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user tries to change the patient appointment schedule that is done by another user, it throws a permission error. This error happens because or event doctype has different permission structure.
I have added event_doc.save(ignore_permissions=True) to fix this.
Error details
"apps/healthcare/healthcare/healthcare/doctype/patient_appointment/patient_appointment.py", line 46, in validate
self.update_event()
File "apps/healthcare/healthcare/healthcare/doctype/patient_appointment/patient_appointment.py", line 350, in update_event
event_doc.save()
File "apps/frappe/frappe/model/document.py", line 309, in save
return self._save(*args, **kwargs)
File "apps/frappe/frappe/model/document.py", line 333, in _save
self.check_permission("write", "save")
File "apps/frappe/frappe/model/document.py", line 196, in check_permission
self.raise_no_permission_to(permtype)
File "apps/frappe/frappe/model/document.py", line 218, in raise_no_permission_to
raise frappe.PermissionError
frappe.exceptions.PermissionError