Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Clip: remove rtree which is causing pip install issues #509

Merged
merged 7 commits into from
Mar 26, 2020

Conversation

lwasser
Copy link

@lwasser lwasser commented Mar 24, 2020

i'm not sure we are even still using it so i'm going to test a local remove to see what happens.

this relates to #507 and should potentially fix it but we need to see how the docs, etc build as well

i'm not sure we are even still using it so i'm going to test a local remove to see what happens.
@lwasser
Copy link
Author

lwasser commented Mar 25, 2020

failing because rtree is missing. and likely it can't install properly via pip as seen locally.
Because we are deprecating clip, we may be able to circle around this however because the clip tests are what is failing.

@lwasser lwasser changed the title rtree is causing pip install issues Deprecate Clip: remove rtree which is causing pip install issues Mar 25, 2020
nkorinek and others added 2 commits March 25, 2020 16:30
* Update codecov from 2.0.15 to 2.0.22 (#506)

* Update tox from 3.14.2 to 3.14.6 (#511)

* Update pytest from 5.3.5 to 5.4.1 (#503)

* Deprecated clip! (I think)

* changelog

* Update CHANGELOG.md

* remote rtree language in readme

Co-authored-by: pyup.io bot <github-bot@pyup.io>
Co-authored-by: Leah Wasser <leah.wasser@colorado.edu>
@codecov-io
Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #509 into master will decrease coverage by 0.55%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
- Coverage      95%   94.44%   -0.56%     
==========================================
  Files          25       25              
  Lines        1660     1585      -75     
==========================================
- Hits         1577     1497      -80     
- Misses         83       88       +5
Impacted Files Coverage Δ
earthpy/tests/test_clip.py 100% <100%> (ø) ⬆️
earthpy/clip.py 70.58% <50%> (-29.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b47238...7b4ebe4. Read the comment docs.

@lwasser
Copy link
Author

lwasser commented Mar 26, 2020

ok. CI is failing here because codecov is simply not working. But this PR actually REMOVES an entire module and so cover coverage is not relevant for this PR. All testing is passing so i'll merge this even tho it looks "broken" it is not. ci is struggling today. as is my internet.

@lwasser lwasser merged commit 8260339 into master Mar 26, 2020
@lwasser lwasser mentioned this pull request Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants