Remove clip #515
Merged
Remove clip #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating earthpy
Updating from EarthPy master
Updating from earthpy repo
Updating from master
Updating from master
Fixed the last two vignettes so that their thumbnails work. (earthlab#407)
Updating!
Updating from master
Updating from master
Updating!
updating from master
Modis data clarification and CI fixes (earthlab#497)
…to remove-rtree
|
@lwasser So Codacy is failing but I can't see why when I click on the details tab. Aside from that it looks like removing clip fixed the CI issues! |
Codecov Report
@@ Coverage Diff @@
## remove-rtree #515 +/- ##
===============================================
Coverage ? 94.44%
===============================================
Files ? 25
Lines ? 1585
Branches ? 0
===============================================
Hits ? 1497
Misses ? 88
Partials ? 0
Continue to review full report at Codecov.
|
|
@nkorinek weird - codacy wasn't able to analyze the PR - so it must be a settings thing. i won't worry too much about that for now! |
lwasser
reviewed
Mar 25, 2020
|
this looks good. i'll test locally. @nkorinek i believe there are a few lines in the readme about rtree installation. can you look for that and remove it as well? THANK YOU again for work on this. I made a very small change to the changelog so you'll want to pull that down first. |
lwasser
pushed a commit
that referenced
this pull request
Mar 26, 2020
* rtree is causing pip install issues i'm not sure we are even still using it so i'm going to test a local remove to see what happens. * Remove clip (#515) * Update codecov from 2.0.15 to 2.0.22 (#506) * Update tox from 3.14.2 to 3.14.6 (#511) * Update pytest from 5.3.5 to 5.4.1 (#503) * Deprecated clip! (I think) * changelog * Update CHANGELOG.md * remote rtree language in readme Co-authored-by: pyup.io bot <github-bot@pyup.io> Co-authored-by: Leah Wasser <leah.wasser@colorado.edu> * small syntax updates * rtd envt slim down * test for rtd resources * cleanup docs envt Co-authored-by: Nathan Korinek <nako1890@colorado.edu> Co-authored-by: pyup.io bot <github-bot@pyup.io>
lwasser
pushed a commit
that referenced
this pull request
Mar 26, 2020
* rtree is causing pip install issues i'm not sure we are even still using it so i'm going to test a local remove to see what happens. * Remove clip (#515) * Update codecov from 2.0.15 to 2.0.22 (#506) * Update tox from 3.14.2 to 3.14.6 (#511) * Update pytest from 5.3.5 to 5.4.1 (#503) * Deprecated clip! (I think) * changelog * Update CHANGELOG.md * remote rtree language in readme Co-authored-by: pyup.io bot <github-bot@pyup.io> Co-authored-by: Leah Wasser <leah.wasser@colorado.edu> * small syntax updates * rtd envt slim down * test for rtd resources * cleanup docs envt * pin deps for RTD * pin more packageS * testing removing conda envt * changelog and pinned deps for the future * black Co-authored-by: Nathan Korinek <nako1890@colorado.edu> Co-authored-by: pyup.io bot <github-bot@pyup.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated clip from the earthpy package. Let me know if I did anything wrong and need to make edits!