Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update buildkit version used for earthly v0.6.0 #1432

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

alexcb
Copy link
Contributor

@alexcb alexcb commented Nov 24, 2021

This sets us to use https://github.com/earthly/buildkit/tree/version-for-earthly-v0.6

Signed-off-by: Alex Couture-Beil alex@earthly.dev

@alexcb
Copy link
Contributor Author

alexcb commented Nov 24, 2021

This only introduces the change where we force the lazyCacheManager to wait:

git log b18e94b75d79364f37a8c27bf6017856d8e20b28..5ee328821a2b2b3cbb84ef6290ba8d1abc910e44
commit 5ee328821a2b2b3cbb84ef6290ba8d1abc910e44 (HEAD -> version-for-earthly-v0.6, earthly/version-for-earthly-v0.6, earthly/acb/rollback-to-f4a607654bbbf4a1eae568d20fddb1f7f7acbf6c-with-kind-fix-and-with-lazy-cache-manager-wait-hack, acb/rollback-to-f4a607654bbbf4a1eae568d20fddb1f7f7acbf6c-with-kind-fix-and-with-lazy-cache-manager-wait-hack, acb/rollback-to-f4a607654bbbf4a1eae568d20fddb1f7f7acbf6c-with-kind-fix)
Author: Alex Couture-Beil <alex@earthly.dev>
Date:   Fri Nov 19 17:29:56 2021 -0800

    force lazyCacheManager.wait to ensure session is active
    
    The lazyCacheManager will sometimes resolve the docker registry
    credentials after the session has been closed; this forces the
    credential resolution to occure while Solve() is still active.
    
    Signed-off-by: Alex Couture-Beil <alex@earthly.dev>

@alexcb alexcb marked this pull request as ready for review November 24, 2021 01:13
Copy link
Contributor

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comment: if we're cutting a branch in buildkit can we name it something like earthly-v0.6 or just v0.6? Just a little bit cleaner and easier to find

@alexcb
Copy link
Contributor Author

alexcb commented Nov 24, 2021

can we name it something like earthly-v0.6 or just v0.6? Just a little bit cleaner and easier to find

earthly-v0.6 sounds good; I was uneasy about calling it v0.6 as it might be confusing about it being buildkit v0.6 vs buildkit-for-v0.6-of-earthly.

@alexcb alexcb merged commit 33eae62 into main Nov 24, 2021
@alexcb alexcb deleted the acb/update-buildkit-version-for-v0.6 branch November 24, 2021 01:27
@alexcb
Copy link
Contributor Author

alexcb commented Nov 24, 2021

Here's the rename of the branch https://github.com/earthly/buildkit/tree/earthly-v0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants